public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Christian Pössinger" <christian@poessinger.com>
To: "'netdev@vger.kernel.org'" <netdev@vger.kernel.org>
Subject: iproute2/tc invalid JSON in v6.0.0-42-g49c63bc7 for "tc filter"
Date: Wed, 16 Nov 2022 17:46:09 +0000	[thread overview]
Message-ID: <e1fa5169db254301bc3b5b766c2df76a@poessinger.com> (raw)

Dear Maintainers,

using revision v6.0.0-42-g49c63bc7 I noticed an invalid JSON output when invoking tc -json filter.

To reproduce the issue:

$ tc qdisc add dev eth1 handle ffff: ingress
$ tc filter add dev eth1 parent ffff: prio 20 protocol all u32 match ip dport 22 \
    0xffff action police conform-exceed drop/ok rate 100000 burst 15k flowid ffff:1

$ tc filter add dev eth1 parent ffff: prio 255 protocol all basic action police \
    conform-exceed drop/ok rate 100000 burst 15k flowid ffff:3


$ tc -detail -json filter show dev eth1 ingress
[{"parent":"ffff:","protocol":"all","pref":20,"kind":"u32","chain":0},{"parent":"ffff:","protocol":"all","pref":20,"kind":"u32","chain":0,
"options":{"fh":"800:","ht_divisor":1}},{"parent":"ffff:","protocol":"all","pref":20,"kind":"u32","chain":0,"options":{"fh":"800::800",
"order":2048,"key_ht":"800","bkt":"0","flowid":"ffff:1","not_in_hw":true,"match":{"value":"16","mask":"ffff","offmask":"","off":20},
"actions":[{"order":1,"kind":"police","index":1,"control_action":{"type":"drop"},"overhead":0,"linklayer":"ethernet","ref":1,"bind":1}]}},
{"parent":"ffff:","protocol":"all","pref":255,"kind":"basic","chain":0},{"parent":"ffff:","protocol":"all","pref":255,"kind":"basic","chain":0,
"options":{handle 0x1 flowid ffff:3 "actions":[{"order":1,"kind":"police","index":2,"control_action":{"type":"drop"},"overhead":0,"linklayer":"ethernet","ref":1,"bind":1}]}}]


>>> json.loads(tmp)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.9/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 698 (char 697)

This actually contains invalid JSON here

... "options":{handle 0x1 flowid ffff:3 "actions":[{"order" ...

It should actually read:

... "options":{"handle":"0x1","flowid":"ffff:3","actions":[{"order" ...

If you can point me to the location which could be responsible for this issue, I am happy to submit a fix to the net tree.

Thanks in advance,
Christian Poessinger

             reply	other threads:[~2022-11-16 18:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 17:46 Christian Pössinger [this message]
2022-11-19 18:56 ` iproute2/tc invalid JSON in v6.0.0-42-g49c63bc7 for "tc filter" Cong Wang
2022-12-01 15:34 ` [PATCH iproute2] tc/basic: fix json output filter Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1fa5169db254301bc3b5b766c2df76a@poessinger.com \
    --to=christian@poessinger.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox