From: David Ahern <dsahern@kernel.org>
To: "Eric Biggers" <ebiggers@kernel.org>,
"Stephen Hemminger" <stephen@networkplumber.org>,
netdev@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: bpf@vger.kernel.org, linux-crypto@vger.kernel.org,
Ard Biesheuvel <ardb@kernel.org>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH iproute2-next v3] lib/bpf_legacy: Use userspace SHA-1 code instead of AF_ALG
Date: Sat, 20 Dec 2025 16:36:38 -0700 [thread overview]
Message-ID: <e1fb9a40-9580-4c6b-8272-2d306a581cd1@kernel.org> (raw)
In-Reply-To: <20251218200910.159349-1-ebiggers@kernel.org>
On 12/18/25 1:09 PM, Eric Biggers wrote:
> diff --git a/include/sha1.h b/include/sha1.h
> new file mode 100644
> index 00000000..4a2ed513
> --- /dev/null
> +++ b/include/sha1.h
> @@ -0,0 +1,18 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * SHA-1 message digest algorithm
> + *
> + * Copyright 2025 Google LLC
> + */
> +#ifndef __SHA1_H__
> +#define __SHA1_H__
> +
> +#include <linux/types.h>
> +#include <stddef.h>
> +
> +#define SHA1_DIGEST_SIZE 20
> +#define SHA1_BLOCK_SIZE 64
How come these are not part of the uapi?
I applied this to iproute2-next to get as much soak time as possible.
Anyone using legacy bpf (added Toke in case he knows) in particular
should test with top of tree.
next prev parent reply other threads:[~2025-12-20 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 20:09 [PATCH iproute2-next v3] lib/bpf_legacy: Use userspace SHA-1 code instead of AF_ALG Eric Biggers
2025-12-20 23:36 ` David Ahern [this message]
2026-01-08 15:42 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1fb9a40-9580-4c6b-8272-2d306a581cd1@kernel.org \
--to=dsahern@kernel.org \
--cc=ardb@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox