From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH net-next 2/2] bpf: reuse tc bpf prologue for sk skb progs Date: Thu, 17 Aug 2017 09:12:07 -0700 Message-ID: References: <5995BEB1.8020509@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: To: John Fastabend , Daniel Borkmann , Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:33628 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbdHQQMV (ORCPT ); Thu, 17 Aug 2017 12:12:21 -0400 In-Reply-To: <5995BEB1.8020509@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 8/17/17 9:05 AM, John Fastabend wrote: > On 08/17/2017 08:22 AM, Daniel Borkmann wrote: >> Given both program types are effecitvely doing the same in the >> prologue, just reuse the one that we had for tc and only adapt >> to the corresponding drop verdict value. That way, we don't need >> to have the duplicate from 8a31db561566 ("bpf: add access to sock >> fields and pkt data from sk_skb programs") to maintain. >> >> Reported-by: Alexei Starovoitov >> Signed-off-by: Daniel Borkmann >> --- >> net/core/filter.c | 47 ++++++++++------------------------------------- >> 1 file changed, 10 insertions(+), 37 deletions(-) >> > > Nice clean-up, Thanks. > > Acked-by: John Fastabend > Acked-by: Alexei Starovoitov