From: Jacob Keller <jacob.e.keller@intel.com>
To: Tariq Toukan <tariqt@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Gal Pressman <gal@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next V2] net/mlx5e: SHAMPO, Switch to header memcpy
Date: Wed, 4 Feb 2026 13:53:16 -0800 [thread overview]
Message-ID: <e2048f08-22ce-48b7-a5b2-dc933fdbda54@intel.com> (raw)
In-Reply-To: <20260204200345.1724098-1-tariqt@nvidia.com>
On 2/4/2026 12:03 PM, Tariq Toukan wrote:
> Performance numbers for x86:
> +---------------------------------------------------------+
> | Test | Baseline | Header Copy | Change |
> |---------------------+------------+-------------+--------|
> | iperf3 oncpu | 59.5 Gbps | 64.00 Gbps | 7 % |
> | iperf3 offcpu | 102.5 Gbps | 104.20 Gbps | 2 % |
> | kperf oncpu | 115.0 Gbps | 130.00 Gbps | 12 % |
> | XDP_DROP (skb mode) | 3.9 Mpps | 3.9 Mpps | 0 % |
> +---------------------------------------------------------+
>
> Notes on test:
> - System: Intel(R) Xeon(R) Platinum 8380 CPU @ 2.30GHz
> - oncpu: NAPI and application running on same CPU
> - offcpu: NAPI and application running on different CPUs
> - MTU: 1500
> - iperf3 tests are single stream, 60s with IPv6 (for slightly larger
> headers)
> - kperf version [1]
>
> [1] git://git.kernel.dk/kperf.git
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en.h | 20 +-
> .../ethernet/mellanox/mlx5/core/en/params.c | 23 --
> .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 1 -
> .../net/ethernet/mellanox/mlx5/core/en_main.c | 287 +++++++--------
> .../net/ethernet/mellanox/mlx5/core/en_rx.c | 341 +++---------------
> 5 files changed, 188 insertions(+), 484 deletions(-)
>
Faster and less code is always a nice thing to see.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2026-02-04 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 20:03 [PATCH net-next V2] net/mlx5e: SHAMPO, Switch to header memcpy Tariq Toukan
2026-02-04 21:53 ` Jacob Keller [this message]
2026-02-06 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2048f08-22ce-48b7-a5b2-dc933fdbda54@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox