From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Jakub Kicinski <kuba@kernel.org>, Gagan Kumar <gagan1kumar.cs@gmail.com>
Cc: matt@codeconstruct.com.au, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mctp: Remove only static neighbour on RTM_DELNEIGH
Date: Fri, 31 Dec 2021 11:33:00 +0800 [thread overview]
Message-ID: <e20e47833649b5141fa327aa8113e34d4b1bbe15.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20211230175112.7daeb74e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Hi Jakub & Gagan,
> > Add neighbour source flag in mctp_neigh_remove(...) to allow
> > removal of only static neighbours.
>
> Which are the only ones that exist today right?
That's correct. There may be a future facility for the kernel to perform
neighbour discovery itself (somewhat analogous to ARP), but only the
static entries are possible at the moment.
> Can you clarify the motivation and practical impact of the change
> in the commit message to make it clear? AFAICT this is a no-op / prep
> for some later changes, right Jeremy?
Yes, it'll be a no-op now; I'm not aware of any changes coming that
require parameterisation of the neighbour type yet.
Gagan - can you provide any context on this change?
Cheers,
Jeremy
next prev parent reply other threads:[~2021-12-31 3:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 13:09 [PATCH] mctp: Remove only static neighbour on RTM_DELNEIGH Gagan Kumar
2021-12-31 1:51 ` Jakub Kicinski
2021-12-31 3:33 ` Jeremy Kerr [this message]
2021-12-31 12:14 ` Gagan Kumar
2022-01-01 2:17 ` Jakub Kicinski
2022-01-01 5:41 ` [PATCH v2] " Gagan Kumar
2022-01-02 12:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e20e47833649b5141fa327aa8113e34d4b1bbe15.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=davem@davemloft.net \
--cc=gagan1kumar.cs@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).