From: Florian Fainelli <f.fainelli@gmail.com>
To: Alex Elder <elder@linaro.org>, davem@davemloft.net, kuba@kernel.org
Cc: bjorn.andersson@linaro.org, evgreen@chromium.org,
cpratapa@codeaurora.org, subashab@codeaurora.org,
elder@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/4] net: ipa: use upper_32_bits()
Date: Thu, 18 Mar 2021 14:35:05 -0700 [thread overview]
Message-ID: <e211d822-ff08-7a83-a0b2-d0be36c30222@gmail.com> (raw)
In-Reply-To: <20210318185930.891260-3-elder@linaro.org>
On 3/18/2021 11:59 AM, Alex Elder wrote:
> Use upper_32_bits() to extract the high-order 32 bits of a DMA
> address. This avoids doing a 32-position shift on a DMA address
> if it happens not to be 64 bits wide. Use lower_32_bits() to
> extract the low-order 32 bits (because that's what it's for).
>
> Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-03-18 21:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 18:59 [PATCH net-next v3 0/4] net: ipa: support 32-bit targets Alex Elder
2021-03-18 18:59 ` [PATCH net-next v3 1/4] net: ipa: fix assumptions about DMA address size Alex Elder
2021-03-18 18:59 ` [PATCH net-next v3 2/4] net: ipa: use upper_32_bits() Alex Elder
2021-03-18 21:35 ` Florian Fainelli [this message]
2021-03-18 18:59 ` [PATCH net-next v3 3/4] net: ipa: fix table alignment requirement Alex Elder
2021-03-18 18:59 ` [PATCH net-next v3 4/4] net: ipa: relax 64-bit build requirement Alex Elder
2021-03-18 23:30 ` [PATCH net-next v3 0/4] net: ipa: support 32-bit targets patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e211d822-ff08-7a83-a0b2-d0be36c30222@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).