From: Pavel Skripkin <paskripkin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: butt3rflyh4ck <butterflyhuangxx@gmail.com>,
Manivannan Sadhasivam <mani@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
butt3rflyh4ck <butterflyhhuangxx@gmail.com>,
bjorn.andersson@linaro.org
Subject: Re: [PATCH] net: qrtr: fix another OOB Read in qrtr_endpoint_post
Date: Fri, 20 Aug 2021 00:16:06 +0300 [thread overview]
Message-ID: <e24737f1-5793-805a-5979-ec564ab1db13@gmail.com> (raw)
In-Reply-To: <20210819140233.5f8d8cd1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 8/20/21 12:02 AM, Jakub Kicinski wrote:
> On Thu, 19 Aug 2021 23:24:39 +0300 Pavel Skripkin wrote:
>> On 8/19/21 11:06 PM, butt3rflyh4ck wrote:
>> > Yes, this bug can be triggered without your change. The reason why I
>> > point to your commit is to make it easier for everyone to understand
>> > this bug.
>>
>> As I understand, purpose of Fixes: tag is to point to commit where the
>> bug was introduced. I could be wrong, so it's up to maintainer to decide
>> is this Fixes: tag is needed or not :)
>
> You're right thanks for pointing that out. May it should actually be:
>
> Fixes: 0baa99ee353c ("net: qrtr: Allow non-immediate node routing") ?
>
Yes, this is correct one. I guess, patch author has chosen 194ccc88297a,
because my commit has same Fixes: tag (wrong one, btw).
With regards,
Pavel Skripkin
prev parent reply other threads:[~2021-08-19 21:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 18:14 [PATCH] net: qrtr: fix another OOB Read in qrtr_endpoint_post butt3rflyh4ck
2021-08-19 19:16 ` Jakub Kicinski
2021-08-19 19:53 ` Pavel Skripkin
2021-08-19 20:06 ` butt3rflyh4ck
2021-08-19 20:24 ` Pavel Skripkin
2021-08-19 21:02 ` Jakub Kicinski
2021-08-19 21:16 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e24737f1-5793-805a-5979-ec564ab1db13@gmail.com \
--to=paskripkin@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=butterflyhhuangxx@gmail.com \
--cc=butterflyhuangxx@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).