From: Andrew Lunn <andrew@lunn.ch>
To: Gregor Herburger <gregor.herburger@ew.tq-group.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Thomas Kopp <thomas.kopp@microchip.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux@ew.tq-group.com
Subject: Re: [PATCH v3 7/8] can: mcp251xfd: add gpio functionality
Date: Tue, 21 May 2024 22:37:33 +0200 [thread overview]
Message-ID: <e24b16a1-2a69-4aea-9ad0-135ed0a87547@lunn.ch> (raw)
In-Reply-To: <20240521-mcp251xfd-gpio-feature-v3-7-7f829fefefc2@ew.tq-group.com>
On Tue, May 21, 2024 at 03:04:57PM +0200, Gregor Herburger wrote:
> The mcp251xfd devices allow two pins to be configured as gpio. Add this
> functionality to driver.
I have a basic understanding of GPIO drivers, which is probably more
than average for netdev reviewers. This code looks O.K. to me, but i
would prefer you run it by the GPIO maintainers, since that is there
domain of expertise. I don't think any are in Cc:
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-05-21 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 13:04 [PATCH v3 0/8] can: mcp251xfd: add gpio functionality Gregor Herburger
2024-05-21 13:04 ` [PATCH v3 1/8] can: mcp251xfd: properly indent labels Gregor Herburger
2024-05-21 13:04 ` [PATCH v3 2/8] can: mcp251xfd: move mcp251xfd_timestamp_start()/stop() into mcp251xfd_chip_start/stop() Gregor Herburger
2024-05-21 13:04 ` [PATCH v3 3/8] can: mcp251xfd: move chip sleep mode into runtime pm Gregor Herburger
2024-05-21 13:04 ` [PATCH v3 4/8] can: mcp251xfd: utilize gather_write function for all non-CRC writes Gregor Herburger
2024-05-21 13:04 ` [PATCH v3 5/8] can: mcp251xfd: add workaround for errata 5 Gregor Herburger
2024-05-21 13:04 ` [PATCH v3 6/8] can: mcp251xfd: only configure PIN1 when rx_int is set Gregor Herburger
2024-05-21 13:04 ` [PATCH v3 7/8] can: mcp251xfd: add gpio functionality Gregor Herburger
2024-05-21 20:37 ` Andrew Lunn [this message]
2024-05-22 8:07 ` Gregor Herburger
2024-05-21 13:04 ` [PATCH v3 8/8] dt-bindings: can: mcp251xfd: add gpio-controller property Gregor Herburger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e24b16a1-2a69-4aea-9ad0-135ed0a87547@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregor.herburger@ew.tq-group.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=thomas.kopp@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox