From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Zhi Li <lizhi2@eswincomputing.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/2] Add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver
Date: Wed, 22 Jul 2026 09:04:10 +0200 [thread overview]
Message-ID: <e2ab85a7-2ddc-4ea0-a004-c5319b846b3e@bootlin.com> (raw)
In-Reply-To: <CAOPX746tZcytWVq-LqE166j8hoVNrndZfZGAgnhiE6Ry_BY8+w@mail.gmail.com>
Hi Artem,
On 7/17/26 12:50, Artem Shimko wrote:
> Hi Maxime,
>
> I could suggest a couple options for how I should handle the driver:
> 1. Recognizing that this is a problem with the PCS layer, I can remove
> the inversion from the patch
> (but add it to my working project as a separate, non-upstream patch).
> This way, we'll just leave the delays setting in the driver, which is
> fairly common among driver users.
> 2. Leave the inversion in the driver until some future common
> framework solution is developed, and
> then adapt this part of the driver to that solution. I'd be happy to
> help develop/modify that framework =).
> A packet generator could also be added to it.
I'd say, you can send the patch without the clock inversion for now, to
keep it simple and generic. If the clock inversion is something that
you really need we can assess that in a second time.
The rest of the driver looks fairly simple and nice :)
Maxime
prev parent reply other threads:[~2026-07-22 7:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 17:33 [PATCH net-next v3 0/2] Add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver Artem Shimko
2026-07-16 17:33 ` [PATCH net-next v3 1/2] dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding Artem Shimko
2026-07-16 19:04 ` Rob Herring (Arm)
2026-07-17 10:54 ` Artem Shimko
2026-07-16 17:33 ` [PATCH net-next v3 2/2] net: phy: add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver Artem Shimko
2026-07-16 18:11 ` [PATCH net-next v3 0/2] Add " Maxime Chevallier
2026-07-16 18:32 ` Andrew Lunn
2026-07-17 10:51 ` Artem Shimko
2026-07-17 10:50 ` Artem Shimko
2026-07-22 7:04 ` Maxime Chevallier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ab85a7-2ddc-4ea0-a004-c5319b846b3e@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=a.shimko.dev@gmail.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lizhi2@eswincomputing.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox