From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Chenguang Zhao <zhaochenguang@kylinos.cn>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>, netdev@vger.kernel.org
Subject: Re: [net-next] net: txgbe: fix phylink leak on AML init failure
Date: Fri, 22 May 2026 09:26:59 +0200 [thread overview]
Message-ID: <e2bbdb18-2af5-4b3d-ab2b-87615581e6bd@bootlin.com> (raw)
In-Reply-To: <20260522070749.1634542-1-zhaochenguang@kylinos.cn>
Hi,
On 5/22/26 09:07, Chenguang Zhao wrote:
> Destroy the phylink instance when fixed-link setup fails.
This should probably be a fix then, targeting the 'net' tree with a
Fixes tag.
>
> Signed-off-by: Chenguang Zhao <zhaochenguang@kylinos.cn>
With the above comment sorted out,
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Maxime
> ---
> drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
> index f0514251d4f3..8e301e7d1148 100644
> --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
> +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
> @@ -521,6 +521,7 @@ int txgbe_phylink_init_aml(struct txgbe *txgbe)
> err = phylink_set_fixed_link(phylink, &state);
> if (err) {
> wx_err(wx, "Failed to set fixed link\n");
> + phylink_destroy(phylink);
> return err;
> }
>
next prev parent reply other threads:[~2026-05-22 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 7:07 [net-next] net: txgbe: fix phylink leak on AML init failure Chenguang Zhao
2026-05-22 7:26 ` Maxime Chevallier [this message]
2026-05-25 1:41 ` Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2bbdb18-2af5-4b3d-ab2b-87615581e6bd@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox