From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next 02/18] ipv6: Mark dead nexthops with appropriate flags Date: Sun, 7 Jan 2018 09:54:03 -0700 Message-ID: References: <20180107104518.31693-1-idosch@mellanox.com> <20180107104518.31693-3-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-pl0-f54.google.com ([209.85.160.54]:37789 "EHLO mail-pl0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753897AbeAGQyF (ORCPT ); Sun, 7 Jan 2018 11:54:05 -0500 Received: by mail-pl0-f54.google.com with SMTP id s3so6249055plp.4 for ; Sun, 07 Jan 2018 08:54:05 -0800 (PST) In-Reply-To: <20180107104518.31693-3-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/7/18 3:45 AM, Ido Schimmel wrote: > When a netdev is put administratively down or unregistered all the > nexthops using it as their nexthop device should be marked with the > 'dead' and 'linkdown' flags. > > Currently, when a route is dumped its nexthop device is tested and the > flags are set accordingly. A similar check is performed during route > lookup. > > Instead, we can simply mark the nexthops based on netdev events and > avoid checking the netdev's state during route dump and lookup. > > Signed-off-by: Ido Schimmel > --- > net/ipv6/route.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: David Ahern