From: "Michał Mirosław" <mirqus@gmail.com>
To: "Ha, Tristram" <Tristram.Ha@micrel.com>
Cc: Dave Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Buesch <mb@bu3sch.de>, Felix Fietkau <openwrt@nbd.name>
Subject: Re: [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver
Date: Sat, 16 Jan 2010 17:00:30 +0100 [thread overview]
Message-ID: <e2d7436a1001160800u11206f54iaf07bb92331a256a@mail.gmail.com> (raw)
In-Reply-To: <14385191E87B904DBD836449AA30269D021A4A@MORGANITE.micrel.com>
Hello,
2010/1/16 Ha, Tristram <Tristram.Ha@micrel.com>:
> This is a new network driver for Micrel KSZ8841/KSZ8842 PCI Ethernet chips. The same driver can run both chips at the same time. It supports IPv4 TCP hardware checksumming and so can use scatter/gather transmission.
>
> The KSZ8842 has a switch with lots of hardware configurations. The driver uses the proc system to allow users to configure the switch. If this is not desired the whole thing can be removed by not calling the init_proc() function.
>
> The KSZ8842 switch has 2 ports. Some users like to take direct control of those ports. So KSZ8842 has a multiple devices mode in which the driver creates another network device so that users can specify which port to send packets. This mode is enabled by passing the "multi_dev=1" parameter to the driver during loading.
[...]
I briefly looked over the datasheet for your device and it looks like
it has the same basic design idea as a "ROBO" switch from Broadcom
that is used in bcm53xx SoCs. This can be seen as a 3-port switch with
one port fixed to be link to CPU (a special kind of PHY).
If my assumptions are correct, then I thing it would be better to have
a driver that presents this device as two: one - an ethernet device,
and second - a switch management interface like the one used in
OpenWRT.
Here are some links for reference:
http://downloads.openwrt.org/kamikaze/8.09.2/kamikaze_8.09.2_source.tar.bz2;
subdir: package/switch/src/
-> switch management driver for ADMTEK Adm6996 and Broadcom BCM5325E/536x
(I'm adding switch driver's authors to CC list. I hope I picket the
correct address for Felix from 3 in the sources. :-)
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2010-01-16 16:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 2:57 [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver Ha, Tristram
2010-01-16 9:20 ` David Miller
2010-01-19 20:03 ` Ha, Tristram
2010-01-19 21:40 ` Stephen Hemminger
2010-01-19 23:48 ` Ha, Tristram
2010-01-20 0:11 ` Stephen Hemminger
2010-01-20 0:34 ` Ha, Tristram
2010-01-20 0:50 ` Stephen Hemminger
2010-01-16 14:50 ` Alan Cox
2010-01-19 21:22 ` Ha, Tristram
2010-01-19 21:32 ` Alan Cox
2010-01-20 0:12 ` Ha, Tristram
2010-01-16 16:00 ` Michał Mirosław [this message]
2010-01-16 16:16 ` Felix Fietkau
2010-01-19 21:51 ` Ha, Tristram
2010-01-19 22:11 ` Felix Fietkau
-- strict thread matches above, loose matches on Subject: below --
2010-01-25 18:14 Jens Rottmann
2010-02-08 21:36 Ha, Tristram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2d7436a1001160800u11206f54iaf07bb92331a256a@mail.gmail.com \
--to=mirqus@gmail.com \
--cc=Tristram.Ha@micrel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=openwrt@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).