From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] net: hns: qdd missing \n to end of dev_err messages Date: Tue, 4 Oct 2016 15:31:54 +0300 Message-ID: References: <20161004110618.11615-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org To: Colin King , Salil Mehta , "David S . Miller" , Kejian Yan , Daode Huang , lipeng , Lisheng , netdev@vger.kernel.org Return-path: In-Reply-To: <20161004110618.11615-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello. On 10/04/2016 02:06 PM, Colin King wrote: > From: Colin Ian King > > Trival fix, dev_err messages are missing a \n, so add it. > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c > index a834774..7aeed08 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c > +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c > @@ -547,7 +547,7 @@ int hns_mac_set_autoneg(struct hns_mac_cb *mac_cb, u8 enable) > struct mac_driver *mac_ctrl_drv = hns_mac_get_drv(mac_cb); > > if (mac_cb->phy_if == PHY_INTERFACE_MODE_XGMII && enable) { > - dev_err(mac_cb->dev, "enable autoneg is not allowed!"); > + dev_err(mac_cb->dev, "enable autoneg is not allowed!\n"); Enabling, perhaps? > return -ENOTSUPP; > } > > @@ -571,7 +571,7 @@ int hns_mac_set_pauseparam(struct hns_mac_cb *mac_cb, u32 rx_en, u32 tx_en) > > if (mac_cb->mac_type == HNAE_PORT_DEBUG) { > if (is_ver1 && (tx_en || rx_en)) { > - dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!"); > + dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!\n"); Perhaps a good time to fix this "cann't"? [...] MBR, Sergei