From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Lendacky Subject: Re: [PATCH net-next v1 02/21] amd-xgbe: Prepare for priority-based FIFO allocation Date: Thu, 3 Nov 2016 09:50:38 -0500 Message-ID: References: <20161103132744.3437.27332.stgit@tlendack-t1.amdoffice.net> <20161103132804.3437.40002.stgit@tlendack-t1.amdoffice.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Florian Fainelli , David Miller To: "Mintz, Yuval" , "netdev@vger.kernel.org" Return-path: Received: from mail-bn3nam01on0064.outbound.protection.outlook.com ([104.47.33.64]:17795 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757937AbcKCOuw (ORCPT ); Thu, 3 Nov 2016 10:50:52 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 11/03/2016 08:51 AM, Mintz, Yuval wrote: >> +static void xgbe_calculate_equal_fifo(unsigned int fifo_size, >> + unsigned int queue_count, >> + unsigned int *fifo) >> +{ > ... >> + >> + return; >> } > > No need for explicit return. > Ok, if there's feedback that requires a v2 I'll remove the return, otherwise I plan to submit a checkpatch cleanup series as a follow-up to fix some of the new warnings issued by the newer version of checkpatch. Thanks, Tom