From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43DB5C7618E for ; Tue, 25 Apr 2023 02:42:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232617AbjDYCmG convert rfc822-to-8bit (ORCPT ); Mon, 24 Apr 2023 22:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbjDYCmF (ORCPT ); Mon, 24 Apr 2023 22:42:05 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D86149EE3; Mon, 24 Apr 2023 19:42:01 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 33P2fiaN7000833, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 33P2fiaN7000833 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Tue, 25 Apr 2023 10:41:44 +0800 Received: from RTEXMBS02.realtek.com.tw (172.21.6.95) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Tue, 25 Apr 2023 10:41:46 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS02.realtek.com.tw (172.21.6.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Tue, 25 Apr 2023 10:41:46 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d]) by RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d%5]) with mapi id 15.01.2375.007; Tue, 25 Apr 2023 10:41:46 +0800 From: Ping-Ke Shih To: Jakub Kicinski , Kalle Valo CC: "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" Subject: RE: pull-request: wireless-next-2023-04-21 Thread-Topic: pull-request: wireless-next-2023-04-21 Thread-Index: AQHZdD60u8zT35eBqkOmWCVcBjPBJa81U6EAgAX6SUA= Date: Tue, 25 Apr 2023 02:41:46 +0000 Message-ID: References: <20230421104726.800BCC433D2@smtp.kernel.org> <20230421075404.63c04bca@kernel.org> In-Reply-To: <20230421075404.63c04bca@kernel.org> Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.69.188] x-kse-serverinfo: RTEXMBS02.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Jakub Kicinski > Sent: Friday, April 21, 2023 10:54 PM > To: Kalle Valo > Cc: netdev@vger.kernel.org; linux-wireless@vger.kernel.org > Subject: Re: pull-request: wireless-next-2023-04-21 > > On Fri, 21 Apr 2023 10:47:26 +0000 (UTC) Kalle Valo wrote: > > .../net/wireless/realtek/rtw89/rtw8851b_table.c | 14824 +++++++++++++++++++ > > .../net/wireless/realtek/rtw89/rtw8851b_table.h | 21 + > > We should load these like FW, see the proposal outlined in > https://lore.kernel.org/all/20221116222339.54052a83@kernel.org/ > for example. Would that not work? > That would work, and I think struct fields addr and val should be __le32. And, I have some draft ideas to handle some situations we will face: 1. upgrading to newer driver without built-in tables will break user space if people don't download table file from linux-firmware.git. Maybe, we can keep the built-in tables and support loading from files for couple years at least. 2. c code can do changes along with these tables, so driver should do some compatibility things for register version. 3. The file contains not only simple registers tables but also TX power tables and power tracking tables. These tables are multiple dimensions, and dimensions can be changed due to more channels are supported, for example. To be backward compatible, we need to add conversion function from v1, v2 ... to current. I will think further to make this change smooth. Ping-Ke