From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BC2C433DB for ; Thu, 11 Feb 2021 04:18:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5932960C40 for ; Thu, 11 Feb 2021 04:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229743AbhBKESg (ORCPT ); Wed, 10 Feb 2021 23:18:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:38170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhBKES2 (ORCPT ); Wed, 10 Feb 2021 23:18:28 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 16CAF64D74; Thu, 11 Feb 2021 04:17:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613017067; bh=eSjD+9pdm7SNENusCDAKtJYA6Md0ExzGn2FWLqgp1Zw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=K2DuBuYe9yGCbebb+aoj+OybG8SLEIEBbb5U3QtI5+S+SRZzcNlKgQrZeI1izk7R6 mo1G1X5inl0A0R9OrSaAS+nDhQvLKnR1JUtwLHkDtKDw3CsCNhgLtPHiZX9CPtrx7S 7SuBS+nrb5zMZRUylMGNxtQ0prqGfXyr344OygNQT8F+6lDKyQpuBgmSCo7LX/9YYP h22OLaEtdyv0QhcEgw9NR8ZGFp3DHLFjiSzysH/ooiZH5VvSqtycxXRs04MRZs97To swknSucyLtdPbHDjmGzeX5pugNOebCcvCqeJm3Fz+XUaZjD4JeFu6LgaKB4tgzzf4K mkYWBpiaZwgQw== Message-ID: Subject: Re: [PATCH net-next] net/mlx5: Fix a NULL vs IS_ERR() check From: Saeed Mahameed To: Vlad Buslov , Dan Carpenter Cc: Leon Romanovsky , "David S. Miller" , Jakub Kicinski , Dmytro Linkin , Roi Dayan , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Wed, 10 Feb 2021 20:17:46 -0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3 (3.38.3-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2021-02-10 at 13:40 +0200, Vlad Buslov wrote: > On Wed 10 Feb 2021 at 13:06, Dan Carpenter > wrote: > > The mlx5_chains_get_table() function doesn't return NULL, it > > returns > > error pointers so we need to fix this condition. > > > > Fixes: 34ca65352ddf ("net/mlx5: E-Switch, Indirect table > > infrastructure") > > Signed-off-by: Dan Carpenter > > Thanks, Dan! > > Reviewed-by: Vlad Buslov Applied to net-next-mlx5 Thanks!