From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next v2 02/13] net: phy: sfp: handle non-wired SFP connectors Date: Fri, 4 May 2018 10:04:48 -0700 Message-ID: References: <20180504135643.23466-1-antoine.tenart@bootlin.com> <20180504135643.23466-3-antoine.tenart@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com, linux-arm-kernel@lists.infradead.org To: Antoine Tenart , davem@davemloft.net, kishon@ti.com, linux@armlinux.org.uk, gregory.clement@bootlin.com, andrew@lunn.ch, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com Return-path: In-Reply-To: <20180504135643.23466-3-antoine.tenart@bootlin.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 05/04/2018 06:56 AM, Antoine Tenart wrote: > SFP connectors can be solder on a board without having any of their pins > (LOS, i2c...) wired. In such cases the SFP link state cannot be guessed, > and the overall link status reporting is left to other layers. > > In order to achieve this, a new SFP_DEV status is added, named UNKNOWN. > This mode is set when it is not possible for the SFP code to get the > link status and as a result the link status is reported to be always UP > from the SFP point of view. Why represent the SFP in Device Tree then? Why not just declare this is a fixed link which would avoid having to introduce this "unknown" state. -- Florian