Netdev List
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Vladimir Oltean" <vladimir.oltean@nxp.com>,
	"Köry Maincent" <kory.maincent@bootlin.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Nicolò Veronese" <nicveronese@gmail.com>,
	"Simon Horman" <horms@kernel.org>,
	mwojtas@chromium.org,
	"Romain Gantois" <romain.gantois@bootlin.com>,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>,
	"Frank Wunderlich" <frank.wunderlich@linux.dev>
Subject: Re: [PATCH net-next v11 06/10] net: phy: phy_port: Store information about a port's upstream
Date: Tue, 26 May 2026 07:54:38 +0200	[thread overview]
Message-ID: <e35a197f-dff7-401d-be1a-9efca61af75f@bootlin.com> (raw)
In-Reply-To: <20260525132537.7fa42301@kernel.org>

Hi Jakub,

On 5/25/26 22:25, Jakub Kicinski wrote:
> On Thu, 21 May 2026 14:10:34 +0200 Maxime Chevallier wrote:
>> --- a/include/linux/phy.h
>> +++ b/include/linux/phy.h
>> @@ -791,6 +791,7 @@ struct phy_device {
>>   	struct sfp_bus *sfp_bus;
>>   	struct phy_port *sfp_cage_port;
>>   	struct phy_port *mod_port;
>> +	struct phy_port *upstream_port;
>>   	struct phylink *phylink;
>>   	struct net_device *attached_dev;
>>   	struct mii_timestamper *mii_ts;
> 
> nit: missing kdoc here

Ah damn, missed that...

> 
> Are all the sashiko reports false positive at this stage?

I'm going through them, it's a mixed bag of correct and incorrect
stuff, I'll reply inline and followup.

Thanks,

Maxime

  reply	other threads:[~2026-05-26  5:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 12:10 [PATCH net-next v11 00/10] net: phy_port: SFP modules representation and phy_port listing Maxime Chevallier
2026-05-21 12:10 ` [PATCH net-next v11 01/10] net: phy: phy_link_topology: Add a helper for opportunistic alloc Maxime Chevallier
2026-05-21 12:10 ` [PATCH net-next v11 02/10] net: phy: phy_link_topology: Track ports in phy_link_topology Maxime Chevallier
2026-05-21 12:10 ` [PATCH net-next v11 03/10] net: phylink: Register a phy_port for MAC-driven SFP cages Maxime Chevallier
2026-05-21 12:10 ` [PATCH net-next v11 04/10] net: phy: Create SFP phy_port before registering upstream Maxime Chevallier
2026-05-21 12:10 ` [PATCH net-next v11 05/10] net: phy: Represent PHY-less SFP modules with phy_port Maxime Chevallier
2026-05-21 12:10 ` [PATCH net-next v11 06/10] net: phy: phy_port: Store information about a port's upstream Maxime Chevallier
2026-05-25 20:25   ` Jakub Kicinski
2026-05-26  5:54     ` Maxime Chevallier [this message]
2026-05-21 12:10 ` [PATCH net-next v11 07/10] net: phy: phy_link_topology: Add a helper to retrieve ports Maxime Chevallier
2026-05-21 12:10 ` [PATCH net-next v11 08/10] netlink: specs: Add ethernet port listing with ethtool Maxime Chevallier
2026-05-21 12:10 ` [PATCH net-next v11 09/10] net: ethtool: Introduce ethtool command to list ports Maxime Chevallier
2026-05-21 12:10 ` [PATCH net-next v11 10/10] Documentation: networking: Update the phy_port infrastructure description Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e35a197f-dff7-401d-be1a-9efca61af75f@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=christophe.leroy@csgroup.eu \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=dimitri.fedrau@liebherr.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=frank.wunderlich@linux.dev \
    --cc=herve.codina@bootlin.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=kabel@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mwojtas@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicveronese@gmail.com \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=romain.gantois@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox