From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>,
"Björn Töpel" <bjorn@kernel.org>
Subject: Re: [PATCH net-next v7 10/10] net: ethtool: Introduce ethtool command to list ports
Date: Thu, 19 Mar 2026 18:52:17 +0100 [thread overview]
Message-ID: <e35c5cde-c631-46f4-850f-4737b1f591d9@bootlin.com> (raw)
In-Reply-To: <20260319075343.0aa9fac8@kernel.org>
On 19/03/2026 15:53, Jakub Kicinski wrote:
> On Thu, 19 Mar 2026 10:27:11 +0100 Maxime Chevallier wrote:
>>> GENL_REQ_ATTR_CHECK ?
>>> I guess you'll have to move it to prepare cause we don't get info
>>> here :(
>>
>> Sorry for my comments coming apart on your review, I'm getting this new
>> iteration done in-between other tasks :(
>>
>> I can't move that check to the prepare_data() step, as we need the
>> request->port_id field to be populated at that stage for the DUMP
>> op (for each port, we set request->port_id, then we call prepare_data
>> and so on).
>
> Not sure I get what you're saying - that it doesn't work or that it
> leads to "duplicated" work?
What I mean is that it doesn't work yeah.
> Alternative is to add info to parse_request
> args which I suspect is useful long term anyway.
good point, I like the idea a lot :) OK let me give this a try, I need
to see how that looks like.
Thanks for the suggestion,
Maxime
prev parent reply other threads:[~2026-03-19 17:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 15:27 [PATCH net-next v7 00/10] net: phy_port: SFP modules representation and phy_port listing Maxime Chevallier
2026-03-09 15:27 ` [PATCH net-next v7 01/10] net: phy: phy_link_topology: Add a helper for opportunistic alloc Maxime Chevallier
2026-03-09 15:27 ` [PATCH net-next v7 02/10] net: phy: phy_link_topology: Track ports in phy_link_topology Maxime Chevallier
2026-03-09 15:27 ` [PATCH net-next v7 03/10] net: phylink: Register a phy_port for MAC-driven SFP busses Maxime Chevallier
2026-03-09 15:27 ` [PATCH net-next v7 04/10] net: phy: Create SFP phy_port before registering upstream Maxime Chevallier
2026-03-09 15:27 ` [PATCH net-next v7 05/10] net: phy: Represent PHY-less SFP modules with phy_port Maxime Chevallier
2026-03-12 10:47 ` [net-next,v7,05/10] " Paolo Abeni
2026-03-12 10:51 ` Paolo Abeni
2026-03-09 15:27 ` [PATCH net-next v7 06/10] net: phylink: " Maxime Chevallier
2026-03-09 15:27 ` [PATCH net-next v7 07/10] net: phy: phy_port: Store information about a MII port's vacant state Maxime Chevallier
2026-03-09 15:27 ` [PATCH net-next v7 08/10] net: phy: phy_link_topology: Add a helper to retrieve ports Maxime Chevallier
2026-03-09 15:27 ` [PATCH net-next v7 09/10] netlink: specs: Add ethernet port listing with ethtool Maxime Chevallier
2026-03-09 15:27 ` [PATCH net-next v7 10/10] net: ethtool: Introduce ethtool command to list ports Maxime Chevallier
2026-03-13 2:07 ` Jakub Kicinski
2026-03-13 8:35 ` Maxime Chevallier
2026-03-18 7:28 ` Maxime Chevallier
2026-03-18 22:00 ` Jakub Kicinski
2026-03-19 9:27 ` Maxime Chevallier
2026-03-19 14:53 ` Jakub Kicinski
2026-03-19 17:52 ` Maxime Chevallier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e35c5cde-c631-46f4-850f-4737b1f591d9@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bjorn@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox