From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next] net: phy: icplus: add config_intr callback Date: Mon, 12 Nov 2018 10:54:35 -0800 Message-ID: References: <31282778-9e55-0f2e-da60-aea11a8c1182@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: Heiner Kallweit , Andrew Lunn , David Miller Return-path: Received: from mail-pg1-f194.google.com ([209.85.215.194]:39740 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727354AbeKMEtS (ORCPT ); Mon, 12 Nov 2018 23:49:18 -0500 Received: by mail-pg1-f194.google.com with SMTP id r9-v6so4461221pgv.6 for ; Mon, 12 Nov 2018 10:54:49 -0800 (PST) In-Reply-To: <31282778-9e55-0f2e-da60-aea11a8c1182@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/11/18 12:49 PM, Heiner Kallweit wrote: > Move IRQ configuration for IP101A/G from config_init to config_intr > callback. Reasons: > > 1. This allows phylib to disable interrupts if needed. > 2. Icplus was the only driver supporting interrupts w/o defining a > config_intr callback. Now we can add a phylib plausibility check > disabling interrupt mode if one of the two irq-related callbacks > isn't defined. > > I don't own hardware with this PHY, and the change is based on the > datasheet for IP101A LF (which is supposed to be register-compatible > with IP101A/G). Change is compile-tested only. > > Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli A bit surprising that this is not a read/modify/write sequence. -- Florian