From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yunsheng Lin Subject: Re: [PATCH][v2] xfrm: replace NR_CPU with nr_cpu_ids Date: Tue, 19 Jun 2018 15:48:44 +0800 Message-ID: References: <1529392300-8298-1-git-send-email-lirongqing@baidu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: Li RongQing , , Return-path: Received: from szxga06-in.huawei.com ([45.249.212.32]:34013 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S937201AbeFSHt7 (ORCPT ); Tue, 19 Jun 2018 03:49:59 -0400 In-Reply-To: <1529392300-8298-1-git-send-email-lirongqing@baidu.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018/6/19 15:11, Li RongQing wrote: > The default NR_CPUS can be very large, but actual possible nr_cpu_ids > usually is very small. For some x86 distribution, the NR_CPUS is 8192 > and nr_cpu_ids is 4, so replace NR_CPU to save some memory > > Signed-off-by: Li RongQing > Signed-off-by: Wang Li > --- > net/xfrm/xfrm_policy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c > index 40b54cc64243..f8188685c1e9 100644 > --- a/net/xfrm/xfrm_policy.c > +++ b/net/xfrm/xfrm_policy.c > @@ -2989,11 +2989,11 @@ void __init xfrm_init(void) > { > int i; > > - xfrm_pcpu_work = kmalloc_array(NR_CPUS, sizeof(*xfrm_pcpu_work), > + xfrm_pcpu_work = kmalloc_array(nr_cpu_ids, sizeof(*xfrm_pcpu_work), > GFP_KERNEL); It seems that xfrm_pcpu_work is not used anymore, maybe it can be deleted to save more memory. > BUG_ON(!xfrm_pcpu_work); > > - for (i = 0; i < NR_CPUS; i++) > + for (i = 0; i < nr_cpu_ids; i++) > INIT_WORK(&xfrm_pcpu_work[i], xfrm_pcpu_work_fn); > > register_pernet_subsys(&xfrm_net_ops); >