From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: Marvell phy errata origins? Date: Wed, 26 Sep 2018 08:35:04 -0700 Message-ID: References: <59691a35-a89c-f9ca-c7b0-73134a737f4c@cisco.com> <20170418140450.GB13724@lunn.ch> <84bfdc12-800c-2f63-3eff-416cf560e18c@cisco.com> <20180925153916.GD1676@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Florian Fainelli , afleming@freescale.com, Harini Katakam , netdev@vger.kernel.org, hramdasi@cisco.com, jpitti@cisco.com, gcasheek@cisco.com To: Harini Katakam , Andrew Lunn Return-path: Received: from alln-iport-4.cisco.com ([173.37.142.91]:3351 "EHLO alln-iport-4.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727184AbeIZVsg (ORCPT ); Wed, 26 Sep 2018 17:48:36 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/25/2018 10:42 PM, Harini Katakam wrote: > Hi, > On Tue, Sep 25, 2018 at 11:00 PM Harini Katakam wrote: >> >> Hi Daniel, >> >> On Tue, Sep 25, 2018 at 9:10 PM Andrew Lunn wrote: >>> >>>> I hope this this thread isn't too old to bring back to life. So it seems >>>> that Harini found that m88e1111 did not need this errata, and Cisco >>>> previously found that Harini's patch fixed m88e1112, we included it >>>> internally for that reason >>>> >>>> Now I'm getting reports that this errata fixes issues we're seeing on >>>> m88e1111. We see an interrupt storm without the errata, despite the errata >>>> not being defined in the datasheet. >>> >>> Is everybody actually using interrupts? It could be in one system >>> phylib is polling. >>> >> >> Yes, we weren't using interrupts; we used phy poll. >> >> As I recall, the register and page combination was reserved and >> the access seemed to fail. >> It will be useful if we can the errata description or version details. >> I'll check if I can get any more information. > > One of the PHY parts used was "88E1111-B2-bab1i000" I doubt I can find this level of detail .. We have many of these machines in the field so they may have different part numbers. I may have been given some incorrect details on the issue. I'm not currently sure this errata code is related. I'll let you know when I have more information. Daniel