netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shannon Nelson <shannon.nelson@oracle.com>
To: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>,
	intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 03/15] ice: Start hardware initialization
Date: Fri, 16 Mar 2018 09:21:16 -0700	[thread overview]
Message-ID: <e39c8a7c-a6ad-3414-fec9-31540b65b010@oracle.com> (raw)
In-Reply-To: <20180315234802.31336-4-anirudh.venkataramanan@intel.com>

On 3/15/2018 4:47 PM, Anirudh Venkataramanan wrote:
> This patch implements multiple pieces of the initialization flow
> as follows:
> 
> 1) A reset is issued to ensure a clean device state, followed
>     by initialization of admin queue interface.
> 
> 2) Once the admin queue interface is up, clear the PF config
>     and transition the device to non-PXE mode.
> 
> 3) Get the NVM configuration stored in the device's non-volatile
>     memory (NVM) using ice_init_nvm.
> 
> CC: Shannon Nelson <shannon.nelson@oracle.com>
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> ---
> v2: Addressed Shannon Nelson's review comments by
>      1) removing an unnecessary register write in ice_aq_clear_pxe_mode.
>      2) adding a comment explaining the need to convert word sized values
>         to byte sized values.

These two changes look fine.

sln

Acked-by: Shannon Nelson <shannon.nelson@oracle.com>

  reply	other threads:[~2018-03-16 16:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 23:47 [PATCH v2 00/15] Add ice driver Anirudh Venkataramanan
2018-03-15 23:47 ` [PATCH v2 01/15] ice: Add basic driver framework for Intel(R) E800 Series Anirudh Venkataramanan
2018-03-15 23:47 ` [PATCH v2 02/15] ice: Add support for control queues Anirudh Venkataramanan
2018-03-15 23:47 ` [PATCH v2 03/15] ice: Start hardware initialization Anirudh Venkataramanan
2018-03-16 16:21   ` Shannon Nelson [this message]
2018-03-15 23:47 ` [PATCH v2 04/15] ice: Get switch config, scheduler config and device capabilities Anirudh Venkataramanan
2018-03-16 16:21   ` Shannon Nelson
2018-03-15 23:47 ` [PATCH v2 05/15] ice: Get MAC/PHY/link info and scheduler topology Anirudh Venkataramanan
2018-03-15 23:47 ` [PATCH v2 06/15] ice: Initialize PF and setup miscellaneous interrupt Anirudh Venkataramanan
2018-03-16 16:21   ` Shannon Nelson
2018-03-15 23:47 ` [PATCH v2 07/15] ice: Add support for VSI allocation and deallocation Anirudh Venkataramanan
2018-03-16 16:21   ` Shannon Nelson
2018-03-15 23:47 ` [PATCH v2 08/15] ice: Add support for switch filter programming Anirudh Venkataramanan
2018-03-15 23:47 ` [PATCH v2 09/15] ice: Configure VSIs for Tx/Rx Anirudh Venkataramanan
2018-03-15 23:47 ` [PATCH v2 10/15] ice: Implement transmit and NAPI support Anirudh Venkataramanan
2018-03-15 23:47 ` [PATCH v2 11/15] ice: Add support for VLANs and offloads Anirudh Venkataramanan
2018-03-15 23:47 ` [PATCH v2 12/15] ice: Add stats and ethtool support Anirudh Venkataramanan
2018-03-15 23:52   ` Stephen Hemminger
2018-03-16  0:50     ` [Intel-wired-lan] " Alexander Duyck
2018-03-16  4:41       ` Stephen Hemminger
2018-03-15 23:48 ` [PATCH v2 13/15] ice: Update Tx scheduler tree for VSI multi-Tx queue support Anirudh Venkataramanan
2018-03-15 23:48 ` [PATCH v2 14/15] ice: Support link events, reset and rebuild Anirudh Venkataramanan
2018-03-15 23:48 ` [PATCH v2 15/15] ice: Implement filter sync, NDO operations and bump version Anirudh Venkataramanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e39c8a7c-a6ad-3414-fec9-31540b65b010@oracle.com \
    --to=shannon.nelson@oracle.com \
    --cc=anirudh.venkataramanan@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).