From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Holger Brunck <holger.brunck@hitachienergy.com>, netdev@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, andrew+netdev@lunn.ch,
qiang.zhao@nxp.com, horms@kernel.org
Subject: Re: [PATCH net] net: wan: fsl_ucc_hdlc: fix indentation error
Date: Tue, 5 May 2026 07:31:19 +0200 [thread overview]
Message-ID: <e3abfd12-6537-42b1-b35e-c79a06f87172@kernel.org> (raw)
In-Reply-To: <20260504160734.2217382-1-holger.brunck@hitachienergy.com>
Hi,
Le 04/05/2026 à 18:07, Holger Brunck a écrit :
> Remove the whitespace to fix the indentation.
Do we really need a patch for that ? What's the added value of doing
this change compared to the cost of doing it ?
>
> Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC")
> Signed-off-by: Holger Brunck <holger.brunck@hitachienergy.com>
> ---
> drivers/net/wan/fsl_ucc_hdlc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 09081f128a98..adf3863463f5 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -764,7 +764,7 @@ static void uhdlc_memclean(struct ucc_hdlc_private *priv)
> qe_muram_free(priv->ucc_pram_offset);
> priv->ucc_pram = NULL;
> priv->ucc_pram_offset = 0;
> - }
> + }
>
> kfree(priv->rx_skbuff);
> priv->rx_skbuff = NULL;
next prev parent reply other threads:[~2026-05-05 5:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 16:07 [PATCH net] net: wan: fsl_ucc_hdlc: fix indentation error Holger Brunck
2026-05-05 5:31 ` Christophe Leroy (CS GROUP) [this message]
2026-05-05 8:16 ` Holger Brunck
2026-05-05 23:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3abfd12-6537-42b1-b35e-c79a06f87172@kernel.org \
--to=chleroy@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=holger.brunck@hitachienergy.com \
--cc=horms@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=qiang.zhao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox