From: Klaus Kudielka <klaus.kudielka@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: don't dispose of Global2 IRQ mappings from mdiobus code
Date: Wed, 15 Mar 2023 07:07:57 +0100 [thread overview]
Message-ID: <e3ae62c36cfe49abc5371009ba6c29cddc2f2ebe.camel@gmail.com> (raw)
In-Reply-To: <20230314200100.7r2pmj3pb4aew7gp@skbuf>
On Tue, 2023-03-14 at 22:01 +0200, Vladimir Oltean wrote:
>
> I'm a bit puzzled as to how you managed to get just this one patch to
> have a different subject-prefix from the others?
A long story, don't laugh at me.
I imported your patch with "git am", but I imported the "mbox" of the
complete message. That was the start of the disaster.
The whole E-mail was in the commit message (also the notes before the
patch), but that was easy to fix.
After git format-patch, checkpatch complained that your "From" E-mail
!= "Signed-off-by" E-mail. Obviously git has taken the "From" from the
first E-mail header.
I looked again at your patch, there it was right, and there was also
a different date (again same root cause).
So I took the shortcut: Just copy/pasted the whole patch header into
the generated patch file, without thinking further -> Boom.
(a) Don't use "git am" blindly
(b) Don't take shortcuts in the process
next prev parent reply other threads:[~2023-03-15 6:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 18:26 [PATCH net-next v3 0/4] net: dsa: mv88e6xxx: accelerate C45 scan Klaus Kudielka
2023-03-14 18:26 ` [PATCH] net: dsa: mv88e6xxx: don't dispose of Global2 IRQ mappings from mdiobus code Klaus Kudielka
2023-03-14 19:35 ` Klaus Kudielka
2023-03-14 20:01 ` Vladimir Oltean
2023-03-15 6:07 ` Klaus Kudielka [this message]
2023-03-15 9:53 ` Vladimir Oltean
2023-03-15 14:41 ` Andrew Lunn
2023-03-14 18:26 ` [PATCH net-next v3 2/4] net: dsa: mv88e6xxx: re-order functions Klaus Kudielka
2023-03-14 18:26 ` [PATCH net-next v3 3/4] net: dsa: mv88e6xxx: move call to mv88e6xxx_mdios_register() Klaus Kudielka
2023-03-14 19:15 ` Andrew Lunn
2023-03-14 18:26 ` [PATCH net-next v3 4/4] net: dsa: mv88e6xxx: mask apparently non-existing phys during probing Klaus Kudielka
2023-03-14 19:23 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ae62c36cfe49abc5371009ba6c29cddc2f2ebe.camel@gmail.com \
--to=klaus.kudielka@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox