public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonas Gorski <jonas.gorski@gmail.com>
To: "Andrew Lunn" <andrew@lunn.ch>,
	"Björn Persson" <Bjorn@xn--rombobjrn-67a.se>
Cc: Wang Zihan <jiyu03@qq.com>,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	kuba@kernel.org
Subject: Re: [PATCH v2] net: switchdev: fix duplicate word in documentation
Date: Sat, 2 May 2026 16:32:22 +0200	[thread overview]
Message-ID: <e3d96025-550b-4268-8e13-ec45d25b0f31@gmail.com> (raw)
In-Reply-To: <a5482c59-2a35-44ce-b112-9c07e8ca7892@lunn.ch>

On 02/05/2026 16:09, Andrew Lunn wrote:
> On Sat, May 02, 2026 at 01:24:46PM +0200, Björn Persson wrote:
>> Wang Zihan wrote:
>>> @@ -162,7 +162,7 @@ The switchdev driver can know a particular port's position in the topology by
>>>  monitoring NETDEV_CHANGEUPPER notifications.  For example, a port moved into a
>>>  bond will see its upper master change.  If that bond is moved into a bridge,
>>>  the bond's upper master will change.  And so on.  The driver will track such
>>> -movements to know what position a port is in in the overall topology by
>>> +movements to know what position a port is in the overall topology by
>>>  registering for netdevice events and acting on NETDEV_CHANGEUPPER.
>>>  
>>>  L2 Forwarding Offload
>>
>> This change claims that a port is a position. The preceding sentences,
>> talking about "a particular port's position" and a port being moved,
>> make it clear that a port is *in* a position *in* the topology. The
>> port is not itself a position.
> 
> I assume this is a fix to make a bot happy, without actually checking
> if the bot is correct.
> 
> Maybe to prevent a recurrence of the bot driver not validating the bot
> output, a ',' should be added?

I'm not a native speaker, but I think moving the first "in" would also
work:

"... to know in what position a port is in the overall topology ..."

Best regards,
Jonas

      reply	other threads:[~2026-05-02 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-02  6:07 [PATCH v2] net: switchdev: fix duplicate word in documentation Wang Zihan
2026-05-02 11:24 ` Björn Persson
2026-05-02 14:09   ` Andrew Lunn
2026-05-02 14:32     ` Jonas Gorski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3d96025-550b-4268-8e13-ec45d25b0f31@gmail.com \
    --to=jonas.gorski@gmail.com \
    --cc=Bjorn@xn--rombobjrn-67a.se \
    --cc=andrew@lunn.ch \
    --cc=jiyu03@qq.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox