From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08FB3C43381 for ; Thu, 14 Feb 2019 04:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CADE72229F for ; Thu, 14 Feb 2019 04:13:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="diN8qaOl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388518AbfBNENe (ORCPT ); Wed, 13 Feb 2019 23:13:34 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:40410 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727739AbfBNENe (ORCPT ); Wed, 13 Feb 2019 23:13:34 -0500 Received: by mail-ot1-f67.google.com with SMTP id s5so8315909oth.7 for ; Wed, 13 Feb 2019 20:13:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P6RKvH7Zo3+j9x8RrR8bfmN6CumBvzsHoNhmkAS+fKU=; b=diN8qaOlo6WslE2JYTAIKLvYx5pHdc1Yop4bIqtxwg7fItRAbZPUVo6Ifqao+Bw9df Lzt5/Ev98bLn8xfAJCtyli9aJdzgAYO7/PzHcLVyesine4mFoaHAJKLdYQmgc2mjqAnI 30BQF+wHNVe1ZRBQyoLDhmrs8bcZms0CI0mTh3XF2FE3OdAY4e6U/TcAadgKmV8ElcF7 YUvJj6zIe20TJQo3IRbmnzKcfF+Y5AOUh5S6YmmQ015+/sKraIyh2fwsvLdsNKxQak/4 Xo1ub4eMQj4zvty2YCB3j2IOEvznoZPhYHQDH3QNUQJ8q/vZmySKcz2oVn1G8HWdef08 LeVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=P6RKvH7Zo3+j9x8RrR8bfmN6CumBvzsHoNhmkAS+fKU=; b=LVa2KhUQtJ4216MXXhlnuqlt7YUhQHajpPp+j8Hz1X3ChnPwWPQiuHsNQR+VOkVKKj AReJEqxAwoGNuCTou0RmoU8LlkW7ybIgjoaMp4yO8GYfbBS2YK0D564RBUlbvqfim+Ss B9u2SXX064iyZRlODNgk/DQxfEgJpMYiUFKFwH5BzB2e6jMwDwn5YsqOSf4cZcB2CChy zOdHbOh3J3zvLhI0UmsDVmwQabrpnKvRfu8SwoKa6XZnQlai4u8jj75Nv8WKHrRU42cI F8KTjl7D9y+rqoK4y1cFSNo8dmYgzXGrXw7xjwW8OjpBsvD39KaCS/L3RwtHUfP4Kn3T HqCw== X-Gm-Message-State: AHQUAuYJSyW4dJ/F/Za8x9oOZII/y8RoFJwuFi+4uoQivxEY48Cb5ma0 dDS4y/zuIKKRAYHsXkucFzEVz+LC X-Google-Smtp-Source: AHgI3IZOfD1GL1Agj+XhWK6UyIHBe9vH4ATmrkpGF8lhfEZFa41mry+MchkiT9wJbAKMtx1mWdwc4g== X-Received: by 2002:a05:6830:1197:: with SMTP id u23mr1011985otq.254.1550117612738; Wed, 13 Feb 2019 20:13:32 -0800 (PST) Received: from [192.168.1.3] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.gmail.com with ESMTPSA id b128sm696175oif.7.2019.02.13.20.13.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 20:13:31 -0800 (PST) Subject: Re: [PATCH net 1/2] net: phy: don't use locking in phy_is_started To: Heiner Kallweit , Andrew Lunn , David Miller Cc: Russell King - ARM Linux , "netdev@vger.kernel.org" References: <2a39271d-3b9e-e425-98b4-b2a24074e806@gmail.com> <2e6abca8-6a60-a7f0-b3e3-0d55fbebd4fc@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0KEZsb3JpYW4gRmFpbmVsbGkgPGZhaW5lbGxpQGJyb2FkY29tLmNvbT6JAccEEAECALEF AlPAG9YXCgABv0jL/n0t8VEFmtDa8j7qERo7AN0gFAAAAAAAFgABa2V5LXVzYWdlLW1hc2tA cGdwLmNvbY4wFIAAAAAAIAAHcHJlZmVycmVkLWVtYWlsLWVuY29kaW5nQHBncC5jb21wZ3Bt aW1lCAsJCAcDAgEKAhkBBReAAAAAGRhsZGFwOi8va2V5cy5icm9hZGNvbS5jb20FGwMAAAAD FgIBBR4BAAAABBUICQoACgkQgTG1xCm8ZqD+Dgf9HhhzqvJYIPomNeg+ll7/TbzWb871E+HQ TaufJQFQwLEbgdFSZO2uj4UqfDpCyTwtHTVMJogWt3pCAE1sadeIY8OlT6918ofKIl8AiHj2 BlfL7ASZ5wzkRMt/4TZoinq9O1tPEynb5G6PdZTV3UQtmSGnpt2EOu7KtRJsnThBiXoOO9TJ Asg4vXJ0ZM1y/MPhQlZbPCHQZFe1gaVWBPLGnLyWyeprqgSLWHaGqrUhlfK1sLuJK1bjYDCI NetK0pS4cA4ZJgogr5FrtV64R19zLl02mt/Yj7rAmjC3ZBuwVi3V35kD8Kd4d9QM2apsiILV bzGbtVCSUgvxI+1SsJEm3bkBDQRTwBvBAQgArGvvWip77T4xgJztZp9YRylAcVTC9gtx0Gg6 eYk/EPANGm9TkuGpI++T/Il2H2TjFQNC7eubWohbYj0+6Tmf8nP+VmyobDxPXcMrK7x4xy9o D+Kub2Vf0SXbsM8fL/SqzGbFWZSm73L1L4GZoxvYIz0i7LExYSX2u5YVLaMBaH9HwKt2cvr7 MuTrRHtcbOZImoXT29g2UnoF1uwxYNeRhZY/lRvVkkY0lDipPuDwg3SpfHMtCybPq1uAswQd gEbHzRsEXwCR1OF3pIuGt4I3tSEhH/k1caqi0BlqjbGUOkku44xC2gf1ZU267FBBkdV3yJ/7 KnrJEnkMCYhS3kII9wARAQABiQJBBBgBAgErBQJTwBvCBRsMAAAAwF0gBBkBCAAGBQJTwBvB AAoJEJNgBqiYLw9VDRUIAJaTef6hsUAESnlGDpC+ymL2RZdzAJx9lXjU4hhaFcyhznuyyMJq d3mehmLxsqDRvHDiqyD71w2Bnc838MVZw0pwBPdnb/h9Ocmp0lL/9hwSGWvy4az5lYVyoA9u 14UIzh0YNGu6jr0isd/LJAbHXqwJwWWs3y8PTrpEp68V6lv+aXt5gR03lJEAvIR1Awp4JJ/e Z5y12gQISp0X8xal9YhhDWER92YLYrO2b6Hc2S31lAupzfCw8lmZsP1PRz1GmF/KmDD9J9N/ b8IehhWQqrBQjMjn2K2XkvN75HnAMHKFYfHZR3ZHtK52ZP1crV7THtbtrnPXVDq+vO4QPmdC +SEACgkQgTG1xCm8ZqC6BwgAl3kRh7oozpjpG8jpO8en5CBtTl3G+OpKJK9qbQyzdCsuJ0K1 qe1wZPZbP/Y+VtmqSgnExBzjStt9drjFBK8liPQZalp2sMlS9S7csSy6cMLF1auZubAZEqpm tpXagbtgR12YOo57Reb83F5KhtwwiWdoTpXRTx/nM0cHtjjrImONhP8OzVMmjem/B68NY++/ qt0F5XTsP2zjd+tRLrFh3W4XEcLt1lhYmNmbJR/l6+vVbWAKDAtcbQ8SL2feqbPWV6VDyVKh ya/EEq0xtf84qEB+4/+IjCdOzDD3kDZJo+JBkDnU3LBXw4WCw3QhOXY+VnhOn2EcREN7qdAK w0j9Sw== Message-ID: Date: Wed, 13 Feb 2019 20:13:28 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <2e6abca8-6a60-a7f0-b3e3-0d55fbebd4fc@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/13/2019 11:11 AM, Heiner Kallweit wrote: > Russell suggested to remove the locking from phy_is_started() because > the read is atomic anyway and actually the locking may be more > misleading. > > Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking") > Suggested-by: Russell King - ARM Linux admin > Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli -- Florian