netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: Gerd Rausch <gerd.rausch@oracle.com>,
	Yanjun Zhu <yanjun.zhu@oracle.com>,
	netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>
Subject: Re: [net-next PATCH] net/rds: Return proper "tos" value to user-space
Date: Thu, 7 Mar 2019 17:37:33 -0800	[thread overview]
Message-ID: <e3e39f23-890a-0b1e-8318-b7d44a027f67@oracle.com> (raw)
In-Reply-To: <20190307220106.9099-1-gerd.rausch@oracle.com>

On 3/7/19 2:01 PM, Gerd Rausch wrote:
> The proper "tos" value needs to be returned
> to user-space (sockopt RDS_INFO_CONNECTIONS).
> 
> Fixes: 3eb450367d08 ("rds: add type of service(tos) infrastructure")
> Signed-off-by: Gerd Rausch <gerd.rausch@oracle.com>
> ---
>   net/rds/connection.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/net/rds/connection.c b/net/rds/connection.c
> index 7ea134f9a825..ed7f2133acc2 100644
> --- a/net/rds/connection.c
> +++ b/net/rds/connection.c
> @@ -736,6 +736,7 @@ static int rds_conn_info_visitor(struct rds_conn_path *cp, void *buffer)
>   	cinfo->next_rx_seq = cp->cp_next_rx_seq;
>   	cinfo->laddr = conn->c_laddr.s6_addr32[3];
>   	cinfo->faddr = conn->c_faddr.s6_addr32[3];
> +	cinfo->tos = conn->c_tos;
>   	strncpy(cinfo->transport, conn->c_trans->t_name,
>   		sizeof(cinfo->transport));
>   	cinfo->flags = 0;
> 
Transport function populates it "iinfo->tos" so 'rds-info -I'
already should be showing the correct output but we should popullate
it here to for socket option so looks good

Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>


  parent reply	other threads:[~2019-03-08  1:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05  0:04 [net-next][PATCH 0/5] rds: add tos support Santosh Shilimkar
2019-02-05  0:04 ` [net-next][PATCH 1/5] rds: make v3.1 as compat version Santosh Shilimkar
2019-02-05  0:04 ` [net-next][PATCH 2/5] rds: rdma: add consumer reject Santosh Shilimkar
2019-02-05  0:04 ` [net-next][PATCH 3/5] rds: add type of service(tos) infrastructure Santosh Shilimkar
     [not found]   ` <20190307220106.9099-1-gerd.rausch@oracle.com>
2019-03-08  1:16     ` [net-next PATCH] net/rds: Return proper "tos" value to user-space Yanjun Zhu
2019-03-08  1:37     ` santosh.shilimkar [this message]
2019-03-08 22:37       ` Gerd Rausch
2019-03-08 22:54         ` Santosh Shilimkar
2019-03-08 23:57         ` Zhu Yanjun
2019-02-05  0:04 ` [net-next][PATCH 4/5] rds: add transport specific tos_map hook Santosh Shilimkar
2019-02-05  0:04 ` [net-next][PATCH 5/5] rds: rdma: update rdma transport for tos Santosh Shilimkar
2019-03-05 16:33   ` Gerd Rausch
2019-03-05 16:41     ` Santosh Shilimkar
2019-03-05 16:48       ` Gerd Rausch
2019-03-05 17:02         ` Santosh Shilimkar
2019-03-06  5:28         ` Yanjun Zhu
     [not found]         ` <20190306070409.26840-1-gerd.rausch@oracle.com>
2019-03-06  8:41           ` [PATCH] net/rds: Accept peer connection reject messages due to incompatible version Yanjun Zhu
     [not found]             ` <20190307014920.24257-1-gerd.rausch@oracle.com>
2019-03-07  1:55               ` [net-next PATCH v2] " Santosh Shilimkar
2019-03-07  2:09                 ` Yanjun Zhu
2019-03-07  3:28                   ` Yanjun Zhu
2019-03-06 17:55           ` [PATCH] " Santosh Shilimkar
2019-02-07  1:01 ` [net-next][PATCH 0/5] rds: add tos support David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3e39f23-890a-0b1e-8318-b7d44a027f67@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=davem@davemloft.net \
    --cc=gerd.rausch@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=yanjun.zhu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).