From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 4/5] net: dsa: add slave get master helper Date: Thu, 12 Oct 2017 16:02:08 -0700 Message-ID: References: <20171012225156.20758-1-vivien.didelot@savoirfairelinux.com> <20171012225156.20758-5-vivien.didelot@savoirfairelinux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn To: Vivien Didelot , netdev@vger.kernel.org Return-path: In-Reply-To: <20171012225156.20758-5-vivien.didelot@savoirfairelinux.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10/12/2017 03:51 PM, Vivien Didelot wrote: > Many part of the DSA slave code require to get the master device > assigned to a slave device. Remove dsa_master_netdev() in favor of a > dsa_slave_get_master() helper which does that. > > Signed-off-by: Vivien Didelot > --- > +static inline struct net_device * > +dsa_slave_get_master(const struct net_device *dev) > +{ > + struct dsa_port *dp = dsa_slave_to_port(dev); > + > + return dp->cpu_dp->netdev; > +} Nit: _get may convey the idea that a reference count may be incremented when the function is called (balanced with a _put), so maybe name it dsa_slave_to_master() which is more in line with dsa_slave_to_port() as well? Other than that: Reviewed-by: Florian Fainelli -- Florian