From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B93C7C433F5 for ; Wed, 6 Apr 2022 12:26:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229460AbiDFM2H (ORCPT ); Wed, 6 Apr 2022 08:28:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232784AbiDFM1L (ORCPT ); Wed, 6 Apr 2022 08:27:11 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7BB23E148C; Wed, 6 Apr 2022 01:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=aEB6aphFsgS6tcwbtUgdYyeAKuuzYXM7RIsKLxa8uvA=; b=Pnmfz+p3TpVQv30t+iXKOy9HP1 IshLmKi2yNidJiLsGu1rxD8klUHG+h5ZfAsdjD5L4N6iEwAzug4A3fZuJOazknB+HBbriHZ2JvTXI cQQ4udex4fEwlGMN5WwHwoOlDn0BIxj/6XHLZ8KoQEEoztSIVbYUuCsIjN+UUrsFR6hk=; Received: from p200300daa70ef200456864e8b8d10029.dip0.t-ipconnect.de ([2003:da:a70e:f200:4568:64e8:b8d1:29] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nc0sP-0003Ng-8L; Wed, 06 Apr 2022 10:18:53 +0200 Message-ID: Date: Wed, 6 Apr 2022 10:18:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Krzysztof Kozlowski , netdev@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Matthias Brugger , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Lorenzo Bianconi Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220405195755.10817-1-nbd@nbd.name> <20220405195755.10817-5-nbd@nbd.name> From: Felix Fietkau Subject: Re: [PATCH v2 04/14] dt-bindings: arm: mediatek: document WED binding for MT7622 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 06.04.22 10:09, Krzysztof Kozlowski wrote: > On 05/04/2022 21:57, Felix Fietkau wrote: >> From: Lorenzo Bianconi >> >> Document the binding for the Wireless Ethernet Dispatch core on the MT7622 >> SoC, which is used for Ethernet->WLAN offloading >> Add related info in mediatek-net bindings. >> >> Signed-off-by: Lorenzo Bianconi >> Signed-off-by: Felix Fietkau > > Thank you for your patch. There is something to discuss/improve. > >> --- >> .../arm/mediatek/mediatek,mt7622-wed.yaml | 50 +++++++++++++++++++ >> .../devicetree/bindings/net/mediatek-net.txt | 2 + >> 2 files changed, 52 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml > > Don't store drivers in arm directory. See: > https://lore.kernel.org/linux-devicetree/YkJa1oLSEP8R4U6y@robh.at.kernel.org/ > > Isn't this a network offload engine? If yes, then probably it should be > in "net/". It's not a network offload engine by itself. It's a SoC component that connects to the offload engine and controls a MTK PCIe WLAN device, intercepting interrupts and DMA rings in order to be able to inject packets coming in from the offload engine. Do you think it still belongs in net, or maybe in soc instead? >> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml >> new file mode 100644 >> index 000000000000..787d6673f952 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml >> @@ -0,0 +1,50 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,mt7622-wed.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: MediaTek Wireless Ethernet Dispatch Controller for MT7622 >> + >> +maintainers: >> + - Lorenzo Bianconi >> + - Felix Fietkau >> + >> +description: >> + The mediatek wireless ethernet dispatch controller can be configured to >> + intercept and handle access to the WLAN DMA queues and PCIe interrupts >> + and implement hardware flow offloading from ethernet to WLAN. >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - mediatek,mt7622-wed >> + - const: syscon >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + wed0: wed@1020a000 { > > Generic node name, "wed" is specific. Maybe "network-offload"? Or > "network-accelerator"? You probably know better what this device does, > so maybe come with some generic name? wed stands for "wireless ethernet dispatch". Both network-offload and network-accelerator don't really fit. Would it make sense to spell it out, or do you have any better naming ideas? Thanks, - Felix