From: Paolo Abeni <pabeni@redhat.com>
To: Aananth V <aananthv@google.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH net-next 2/2] tcp: new TCP_INFO stats for RTO events
Date: Thu, 14 Sep 2023 11:02:05 +0200 [thread overview]
Message-ID: <e3ed5c1e03d14dabb073bbb6d56f0fb825e770a4.camel@redhat.com> (raw)
In-Reply-To: <20230912023309.3013660-3-aananthv@google.com>
Hi,
On Tue, 2023-09-12 at 02:33 +0000, Aananth V wrote:
> @@ -2825,6 +2829,14 @@ void tcp_enter_recovery(struct sock *sk, bool ece_ack)
> tcp_set_ca_state(sk, TCP_CA_Recovery);
> }
>
> +static inline void tcp_update_rto_time(struct tcp_sock *tp)
> +{
> + if (tp->rto_stamp) {
> + tp->total_rto_time += tcp_time_stamp(tp) - tp->rto_stamp;
> + tp->rto_stamp = 0;
> + }
> +}
The CI is complaining about 'inline' function in .c file. I guess that
is not by accident and the goal is to maximize fast-path performances?
Perhaps worthy moving the function to an header file to make static
checkers happy?
Thanks!
Paolo
next prev parent reply other threads:[~2023-09-14 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 2:33 [PATCH net-next 0/2] tcp: new TCP_INFO stats for RTO events Aananth V
2023-09-12 2:33 ` [PATCH net-next 1/2] tcp: call tcp_try_undo_recovery when an RTOd TFO SYNACK is ACKed Aananth V
2023-09-12 2:33 ` [PATCH net-next 2/2] tcp: new TCP_INFO stats for RTO events Aananth V
2023-09-14 9:02 ` Paolo Abeni [this message]
2023-09-14 13:36 ` Yuchung Cheng
2023-09-14 14:16 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ed5c1e03d14dabb073bbb6d56f0fb825e770a4.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=aananthv@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).