From: Jonathan Toppins <jtoppins@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Paolo Abeni <pabeni@redhat.com>, Li Liang <liali@redhat.com>
Subject: Re: [PATCH net] bonding: NS target should accept link local address
Date: Fri, 27 May 2022 10:05:56 -0400 [thread overview]
Message-ID: <e3f7d861-1f92-f30f-8f9d-35dfc59d1c1a@redhat.com> (raw)
In-Reply-To: <20220527064439.1837544-1-liuhangbin@gmail.com>
On 5/27/22 02:44, Hangbin Liu wrote:
> When setting bond NS target, we use bond_is_ip6_target_ok() to check
> if the address valid. The link local address was wrongly rejected in
> bond_changelink(), as most time the user just set the ARP/NS target to
> gateway, while the IPv6 gateway is always a link local address when user
> set up interface via SLAAC.
>
> So remove the link local addr check when setting bond NS target.
>
> Fixes: 129e3c1bab24 ("bonding: add new option ns_ip6_target")
> Reported-by: Li Liang <liali@redhat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Jonathan Toppins <jtoppins@redhat.com>
next prev parent reply other threads:[~2022-05-27 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 6:44 [PATCH net] bonding: NS target should accept link local address Hangbin Liu
2022-05-27 14:05 ` Jonathan Toppins [this message]
2022-05-27 23:28 ` Jay Vosburgh
2022-05-28 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3f7d861-1f92-f30f-8f9d-35dfc59d1c1a@redhat.com \
--to=jtoppins@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).