Netdev List
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Victor Nogueira <victor@mojatatu.com>
Cc: netdev@vger.kernel.org, hexlabsecurity@proton.me,
	pctammela@mojatatu.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, jhs@mojatatu.com, jiri@resnulli.us
Subject: Re: [PATCH net] selftests/tc-testing: Add tests that force multiq and taprio to enqueue to child's gso_skb
Date: Fri, 3 Jul 2026 18:37:44 +0200	[thread overview]
Message-ID: <e3f99de6-cf19-451f-8175-50fa30012f7f@redhat.com> (raw)
In-Reply-To: <20260630153651.249752-1-victor@mojatatu.com>

On 6/30/26 5:36 PM, Victor Nogueira wrote:
> Add test cases to reproduce scenarios fixed recently [1] where
> multiqueue and taprio forced their children into enqueueing an skb to
> gso_skb (during peek), but failed to dequeue from gso_skb because they
> called the child's dequeue callback directly. This causes a desync in the
> child's qlen/backlog and results in an eventual null-ptr-deref (with a
> qfq or dualpi2 child).
> 
> Test cases are the following:
> 
> - Force multiq to dequeue from its child's gso_skb with qfq leaf (fb6c)
> - Force multiq to dequeue from its child's gso_skb with dualpi2 leaf (1922)
> - Force taprio to dequeue from its child's gso_skb with qfq leaf (476f)
> - Force taprio to dequeue from its child's gso_skb with dualpi2 leaf (0235)
> 
> [1] https://lore.kernel.org/netdev/20260625-b4-disp-31bcb279-v1-0-85c40b83c529@proton.me/
> 
> Signed-off-by: Victor Nogueira <victor@mojatatu.com>

Since the fix has been propagated to net-next, this is net-next
material, right? no need to repost, just ack/nack, thanks!

/P


  parent reply	other threads:[~2026-07-03 16:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 15:36 [PATCH net] selftests/tc-testing: Add tests that force multiq and taprio to enqueue to child's gso_skb Victor Nogueira
2026-06-30 15:43 ` Pedro Tammela
2026-07-03 16:37 ` Paolo Abeni [this message]
2026-07-03 16:57   ` Victor Nogueira
2026-07-06 10:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3f99de6-cf19-451f-8175-50fa30012f7f@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hexlabsecurity@proton.me \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pctammela@mojatatu.com \
    --cc=victor@mojatatu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox