From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v3] net: qcom/emac: extend DMA mask to 46bits Date: Mon, 20 Nov 2017 09:07:33 -0600 Message-ID: References: <1511185682-18324-1-git-send-email-wdsch86@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Wang Dongsheng Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:49406 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbdKTPHg (ORCPT ); Mon, 20 Nov 2017 10:07:36 -0500 In-Reply-To: <1511185682-18324-1-git-send-email-wdsch86@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: This is much better. Can you give me a few days to test it on some internal platforms? Also, this is a candidate for 4.16, so you need to wait until net-next is open anyway (http://vger.kernel.org/~davem/net-next.html). On 11/20/17 7:48 AM, Wang Dongsheng wrote: > Since PTP doesn't support yet, so extend the DMA address to 46bits. This needs to be longer, since it's not clear that TPD3[31] is bot a timestamp bit and an address bit. How about this: Bit TPD3[31] is used as a timestamp bit if PTP is enabled, but it's used as an address bit if PTP is disabled. Since PTP isn't supported by the driver, we can extend the DMA address to 46 bits. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.