From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] net: igmp: make function __ip_mc_inc_group() static Date: Wed, 25 Jul 2018 06:19:56 -0700 Message-ID: References: <1532498773-188363-1-git-send-email-weiyongjun1@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Wei Yongjun , Alexey Kuznetsov , Hideaki YOSHIFUJI , Hangbin Liu Return-path: Received: from mail-pg1-f195.google.com ([209.85.215.195]:40771 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728864AbeGYObh (ORCPT ); Wed, 25 Jul 2018 10:31:37 -0400 In-Reply-To: <1532498773-188363-1-git-send-email-weiyongjun1@huawei.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/24/2018 11:06 PM, Wei Yongjun wrote: > Fixes the following sparse warnings: > > net/ipv4/igmp.c:1391:6: warning: > symbol '__ip_mc_inc_group' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun > --- > net/ipv4/igmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c > index 598333b..c9f8d46 100644 > --- a/net/ipv4/igmp.c > +++ b/net/ipv4/igmp.c > @@ -1388,7 +1388,8 @@ static void ip_mc_hash_remove(struct in_device *in_dev, > /* > * A socket has joined a multicast group on device dev. > */ > -void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, unsigned int mode) > +static void __ip_mc_inc_group(struct in_device *in_dev, __be32 addr, > + unsigned int mode) > { > struct ip_mc_list *im; > #ifdef CONFIG_IP_MULTICAST > This should target net tree Fixes: 6e2059b53f98 ("ipv4/igmp: init group mode as INCLUDE when join source group")