From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Williams <dcbw@redhat.com>,
Ajay.Kathat@microchip.com, kvalo@kernel.org,
heiko.thiery@gmail.com
Cc: michael@walle.cc, kuba@kernel.org, Claudiu.Beznea@microchip.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Amisha.Patel@microchip.com, thaller@redhat.com,
bgalvani@redhat.com, Sripad.Balwadgi@microchip.com
Subject: Re: wilc1000 MAC address is 00:00:00:00:00:00
Date: Wed, 15 Feb 2023 21:14:10 +0100 [thread overview]
Message-ID: <e455e26830a0d8f2ce728461b74e6dbd4b315df5.camel@sipsolutions.net> (raw)
In-Reply-To: <aef63f6a367896950f9e61041cfcff4b99bd6c7d.camel@redhat.com>
On Fri, 2023-02-10 at 15:28 -0600, Dan Williams wrote:
> >
> > In wilc1000, the bus interface is up in probe but we don't have
> > access
> > to mac address via register until the driver starts the wilc firmware
> > because of design limitation. This information is only available
> > after
> > the MAC layer is initialized.
>
> So... initialize the MAC layer and read the address, then stop the card
> until dev open which reloads and reinits? That's what eg Atmel does
For a more modern example, iwlwifi also ;-)
You should also load the firmware async, so it becomes:
probe
-> load firmware
firmware success callback
- boot device
- read information
- register with mac80211
- shut down device
mac80211 start callback
- boot device again
- etc.
johannes
next prev parent reply other threads:[~2023-02-15 20:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 14:24 wilc1000 MAC address is 00:00:00:00:00:00 Heiko Thiery
2023-02-09 17:15 ` Ajay.Kathat
2023-02-09 17:48 ` Jakub Kicinski
2023-02-09 18:51 ` Ajay.Kathat
2023-02-09 21:07 ` Jakub Kicinski
2023-02-09 21:19 ` Michael Walle
2023-02-10 9:17 ` Heiko Thiery
2023-02-10 9:25 ` Kalle Valo
2023-02-10 19:12 ` Ajay.Kathat
2023-02-10 21:28 ` Dan Williams
2023-02-15 20:14 ` Johannes Berg [this message]
2023-02-23 10:44 ` Heiko Thiery
2023-02-23 21:48 ` Ajay.Kathat
2023-02-09 18:40 ` Heiko Thiery
2023-02-09 19:09 ` Ajay.Kathat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e455e26830a0d8f2ce728461b74e6dbd4b315df5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Ajay.Kathat@microchip.com \
--cc=Amisha.Patel@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Sripad.Balwadgi@microchip.com \
--cc=bgalvani@redhat.com \
--cc=dcbw@redhat.com \
--cc=heiko.thiery@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).