From: Florian Fainelli <f.fainelli@gmail.com>
To: Timur Tabi <timur@codeaurora.org>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org,
Christopher Covington <cov@codeaurora.org>,
alokc@codeaurora.org
Subject: Re: [PATCH] net: qcom/emac: don't try to claim clocks on ACPI systems
Date: Tue, 13 Dec 2016 14:02:15 -0800 [thread overview]
Message-ID: <e4666d2c-1690-0513-b2e2-57733f04a69c@gmail.com> (raw)
In-Reply-To: <58506E00.9040801@codeaurora.org>
On 12/13/2016 01:54 PM, Timur Tabi wrote:
> On 12/13/2016 03:46 PM, Florian Fainelli wrote:
>> Is there a reason why the check is not moved down inwo
>> emac_clks_phase{1,2}_init functions? Do you anticipate other
>> ACPI-related changes in the future that would warrant having this check
>> moved at a higher level?
>
> No, this is the last ACPI-related change that I expect. I could move
> the check into those functions, but I don't see how that's any different
> than what I'm doing now. My way avoids calling a function altogether,
> your way calls into a function only to have it return immediately.
>
> But I don't have any strong feelings either way. I will change it if
> you want me to.
No strong feelings either, it just seems easier and safer to move the
check down in the function and make it return success rather than
potentially affecting the error path within the caller of
emac_clks_phase{1,2}_init here.
--
Florian
next prev parent reply other threads:[~2016-12-13 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 19:55 [PATCH] net: qcom/emac: don't try to claim clocks on ACPI systems Timur Tabi
2016-12-13 21:46 ` Florian Fainelli
2016-12-13 21:54 ` Timur Tabi
2016-12-13 22:02 ` Florian Fainelli [this message]
2016-12-13 22:05 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4666d2c-1690-0513-b2e2-57733f04a69c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alokc@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).