From: Heiner Kallweit <hkallweit1@gmail.com>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>,
"Eric Dumazet" <edumazet@google.com>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Sander Eikelenboom <linux@eikelenboom.it>
Subject: Re: [PATCH net-next] r8169: make use of xmit_more
Date: Fri, 9 Aug 2019 22:28:54 +0200 [thread overview]
Message-ID: <e46acb1c-36e9-2713-694e-9122b7b166bb@gmail.com> (raw)
In-Reply-To: <72a58a6b-974c-0feb-2fa4-c8a71c7eff7e@applied-asynchrony.com>
On 09.08.2019 10:52, Holger Hoffstätte wrote:
> On 8/9/19 10:25 AM, Eric Dumazet wrote:
> (snip)
>>>
>>> So that didn't take long - got another timeout this morning during some
>>> random light usage, despite sg/tso being disabled this time.
>>> Again the only common element is the xmit_more patch. :(
>>> Not sure whether you want to revert this right away or wait for 5.4-rc1
>>> feedback. Maybe this too is chipset-specific?
>>>
>>>> Thanks a lot for the analysis and testing. Then I'll submit the disabling
>>>> of SG on RTL8168evl (on your behalf), independent of whether it fixes
>>>> the timeout issue.
>>>
>>> Got it, thanks!
>>>
>>> Holger
>>
>> I would try this fix maybe ?
>>
>> diff --git a/drivers/net/ethernet/realtek/r8169_main.c
>> b/drivers/net/ethernet/realtek/r8169_main.c
>> index b2a275d8504cf099cff738f2f7554efa9658fe32..e77628813daba493ad50dab9ac1e3703e38b560c
>> 100644
>> --- a/drivers/net/ethernet/realtek/r8169_main.c
>> +++ b/drivers/net/ethernet/realtek/r8169_main.c
>> @@ -5691,6 +5691,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
>> */
>> smp_wmb();
>> netif_stop_queue(dev);
>> + door_bell = true;
>> }
>>
>> if (door_bell)
>>
>
> Thanks Eric, I'll give that a try and see how it fares over the next few days.
> It suspiciously looks like it could help..
>
> -h
>
Thanks for testing this. Looking forward to your feedback regarding the change.
Heiner
next prev parent reply other threads:[~2019-08-09 20:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 9:25 [PATCH net-next] r8169: make use of xmit_more Heiner Kallweit
2019-07-29 18:05 ` David Miller
2019-08-08 14:37 ` Holger Hoffstätte
2019-08-08 15:53 ` Holger Hoffstätte
2019-08-08 18:17 ` Heiner Kallweit
2019-08-08 19:52 ` Holger Hoffstätte
2019-08-08 20:08 ` Heiner Kallweit
2019-08-09 8:04 ` Holger Hoffstätte
2019-08-09 8:25 ` Eric Dumazet
2019-08-09 8:52 ` Holger Hoffstätte
2019-08-09 20:28 ` Heiner Kallweit [this message]
2019-08-12 9:59 ` Holger Hoffstätte
2019-08-12 18:38 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e46acb1c-36e9-2713-694e-9122b7b166bb@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=holger@applied-asynchrony.com \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).