From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>,
Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [PATCH net] ipv6: prevent possible NULL deref in fib6_nh_init()
Date: Fri, 14 Jun 2024 08:40:17 -0600 [thread overview]
Message-ID: <e48a44aa-ae66-4758-9c88-8ae28b699496@kernel.org> (raw)
In-Reply-To: <20240614082002.26407-1-edumazet@google.com>
On 6/14/24 2:20 AM, Eric Dumazet wrote:
> syzbot reminds us that in6_dev_get() can return NULL.
>
> fib6_nh_init()
> ip6_validate_gw( &idev )
> ip6_route_check_nh( idev )
> *idev = in6_dev_get(dev); // can be NULL
>
...
> Fixes: 428604fb118f ("ipv6: do not set routes if disable_ipv6 has been enabled")
> Reported-by: syzbot <syzkaller@googlegroups.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> net/ipv6/route.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-06-14 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 8:20 [PATCH net] ipv6: prevent possible NULL deref in fib6_nh_init() Eric Dumazet
2024-06-14 8:29 ` Lorenzo Bianconi
2024-06-14 14:40 ` David Ahern [this message]
2024-06-18 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e48a44aa-ae66-4758-9c88-8ae28b699496@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).