From: Florian Fainelli <f.fainelli@gmail.com>
To: Michal Kubecek <mkubecek@suse.cz>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: Maya Erez <merez@codeaurora.org>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
Francois Romieu <romieu@fr.zoreil.com>,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2 1/3] wil6210: get rid of begin() and complete() ethtool_ops
Date: Mon, 6 Jan 2020 10:30:47 -0800 [thread overview]
Message-ID: <e491e623-dd95-b453-4656-c18f6526562c@gmail.com> (raw)
In-Reply-To: <27c09c8633c2c34a78ae528e5f4850bcd964acc7.1578292157.git.mkubecek@suse.cz>
On 1/5/20 10:39 PM, Michal Kubecek wrote:
> The wil6210 driver locks a mutex in begin() ethtool_ops callback and
> unlocks it in complete() so that all ethtool requests are serialized. This
> is not going to work correctly with netlink interface; e.g. when ioctl
> triggers a netlink notification, netlink code would call begin() again
> while the mutex taken by ioctl code is still held by the same task.
>
> Let's get rid of the begin() and complete() callbacks and move the mutex
> locking into the remaining ethtool_ops handlers except get_drvinfo which
> only copies strings that are not changing so that there is no need for
> serialization.
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-01-06 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 6:39 [PATCH net-next v2 0/3] ethtool: allow nesting of begin() and complete() callbacks Michal Kubecek
2020-01-06 6:39 ` [PATCH net-next v2 1/3] wil6210: get rid of begin() and complete() ethtool_ops Michal Kubecek
2020-01-06 18:30 ` Florian Fainelli [this message]
2020-01-06 6:39 ` [PATCH net-next v2 2/3] via-velocity: allow nesting of ethtool_ops begin() and complete() Michal Kubecek
2020-01-06 6:39 ` [PATCH net-next v2 3/3] epic100: " Michal Kubecek
2020-01-06 8:41 ` [PATCH net-next v2 0/3] ethtool: allow nesting of begin() and complete() callbacks Simon Horman
2020-01-06 21:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e491e623-dd95-b453-4656-c18f6526562c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).