From: Florian Fainelli <f.fainelli@gmail.com>
To: Robert Marko <robert.marko@sartura.hr>,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org
Subject: Re: [net-next,PATCH 2/4] net: mdio-ipq4019: add clock support
Date: Thu, 2 Jul 2020 12:59:09 -0700 [thread overview]
Message-ID: <e4921b83-0c80-65ad-6ddd-be2a12347d9c@gmail.com> (raw)
In-Reply-To: <20200702103001.233961-3-robert.marko@sartura.hr>
On 7/2/2020 3:29 AM, Robert Marko wrote:
> Some newer SoC-s have a separate MDIO clock that needs to be enabled.
> So lets add support for handling the clocks to the driver.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> drivers/net/phy/mdio-ipq4019.c | 28 +++++++++++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/mdio-ipq4019.c b/drivers/net/phy/mdio-ipq4019.c
> index 0e78830c070b..7660bf006da0 100644
> --- a/drivers/net/phy/mdio-ipq4019.c
> +++ b/drivers/net/phy/mdio-ipq4019.c
> @@ -9,6 +9,7 @@
> #include <linux/iopoll.h>
> #include <linux/of_address.h>
> #include <linux/of_mdio.h>
> +#include <linux/clk.h>
> #include <linux/phy.h>
> #include <linux/platform_device.h>
>
> @@ -24,8 +25,12 @@
> #define IPQ4019_MDIO_TIMEOUT 10000
> #define IPQ4019_MDIO_SLEEP 10
>
> +#define QCA_MDIO_CLK_DEFAULT_RATE 100000000
100MHz? Is not that going to be a tad too much for most MDIO devices out
there?
--
Florian
next prev parent reply other threads:[~2020-07-02 19:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 10:29 [net-next,PATCH 0/4] net: mdio-ipq4019: add Clause 45 and clock support Robert Marko
2020-07-02 10:29 ` [net-next,PATCH 1/4] net: mdio-ipq4019: change defines to upper case Robert Marko
2020-07-02 13:25 ` Andrew Lunn
2020-07-02 19:58 ` Florian Fainelli
2020-07-02 10:29 ` [net-next,PATCH 2/4] net: mdio-ipq4019: add clock support Robert Marko
2020-07-02 13:29 ` Andrew Lunn
2020-07-02 19:59 ` Florian Fainelli [this message]
2020-07-03 11:37 ` Robert Marko
2020-07-03 13:35 ` Andrew Lunn
2020-07-02 10:30 ` [net-next,PATCH 3/4] net: mdio-ipq4019: add Clause 45 support Robert Marko
2020-07-02 13:35 ` Andrew Lunn
2020-07-02 10:30 ` [net-next,PATCH 4/4] dt-bindings: mdio-ipq4019: add clock support Robert Marko
2020-07-02 13:38 ` Andrew Lunn
2020-07-02 19:18 ` Robert Marko
2020-07-02 20:04 ` Florian Fainelli
2020-07-03 7:44 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4921b83-0c80-65ad-6ddd-be2a12347d9c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=agross@kernel.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).