From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0A4C3A59C for ; Fri, 16 Aug 2019 17:18:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6168220665 for ; Fri, 16 Aug 2019 17:18:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="pVDHlYdL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727382AbfHPRSo (ORCPT ); Fri, 16 Aug 2019 13:18:44 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:53659 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbfHPRSn (ORCPT ); Fri, 16 Aug 2019 13:18:43 -0400 Received: by mail-wm1-f68.google.com with SMTP id 10so4616040wmp.3 for ; Fri, 16 Aug 2019 10:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VEpvMr6ivcf9WYnfA07psMPftiHLyAntmf06aiMMcGc=; b=pVDHlYdLtNZXqDuB8Fncscb1bTg2fD/EaFej91GPpvS+Wd1Agb9cBAeB3ilrtJhq/5 0MoGPSA8ZMtXOvcKDhWypyLBiwBcuQf8SLjR9F2rsEP6/gzarKIFgSoJenrAU5/jtmK5 xGNPhnCQft6lHRmwRRGiXRx3ynPijTtKYZIUumJOTYyYplSjXauIKL86JaKzyPwUYX3w 3SJD9a2vzUD7ZuuaOk364SskcDRMbreN5alhDXoPhbBh5xk1K2WZfgbiqb1OUob54Eaj alAnsFgkE2hsYXLJ2CxCXOWte/Bcwz+BZh1FrZXwxiRPnkERJ4yIGF5dYVIdz88bvD+v 7u3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VEpvMr6ivcf9WYnfA07psMPftiHLyAntmf06aiMMcGc=; b=s7K+pjol2uHC0KetWersv8D+llrJ33s1A6ubdpMLdz83t1dDt0lVgLB4pmFA9YGMKG iJhr93pK6Z88RvxD3y/OOFNp2NxlAG4BdC+6U/XA1LjIiF9S7kJ5+jB9SFWuTWFLbvTa 988o4WgdtCAcHqVj2ofHONjNN8j3HT4s86Yh2atAW5U4PoZdq9JuvmfXcGBTHsKiqDVt S1BZcF9zY4KrT3S+fp3++zyhrwoAyDhnThQ88elabRGKeCyqDMGt+y/+gBHmGTuIbmEw kiRTt+2qWtzd11saILroR1R6v8EM6nyy4rqbRm9qvqKfe/Us6QJIyZfyPXF96RqcX3tF iitw== X-Gm-Message-State: APjAAAVZwC1YCHXW6sJXxAPF2JICwSQUxP4GYKm56oDSxLVKcPL3S76W gWeFed8Ry/s26FJRNtF4mjmuxQ== X-Google-Smtp-Source: APXvYqyiUe1A/SXrSgtpg9pIW6xotblDwEltLj/uXPj0+cvP2Rs4MuyRZR1EMckBVoRCRBPl34Iufg== X-Received: by 2002:a05:600c:d2:: with SMTP id u18mr8252966wmm.11.1565975922501; Fri, 16 Aug 2019 10:18:42 -0700 (PDT) Received: from [192.168.1.2] ([194.53.186.47]) by smtp.gmail.com with ESMTPSA id f7sm10847854wrf.8.2019.08.16.10.18.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Aug 2019 10:18:41 -0700 (PDT) Subject: Re: [PATCH bpf 0/6] tools: bpftool: fix printf()-like functions To: Alexei Starovoitov Cc: Alexei Starovoitov , Daniel Borkmann , bpf , Network Development , oss-drivers@netronome.com References: <20190815143220.4199-1-quentin.monnet@netronome.com> <10602447-213f-fce5-54c7-7952eb3e8712@netronome.com> From: Quentin Monnet Message-ID: Date: Fri, 16 Aug 2019 18:18:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2019-08-16 10:11 UTC-0700 ~ Alexei Starovoitov > On Fri, Aug 16, 2019 at 9:41 AM Quentin Monnet > wrote: >> >> 2019-08-15 22:08 UTC-0700 ~ Alexei Starovoitov >> >>> On Thu, Aug 15, 2019 at 7:32 AM Quentin Monnet >>> wrote: >>>> >>>> Hi, >>>> Because the "__printf()" attributes were used only where the functions are >>>> implemented, and not in header files, the checks have not been enforced on >>>> all the calls to printf()-like functions, and a number of errors slipped in >>>> bpftool over time. >>>> >>>> This set cleans up such errors, and then moves the "__printf()" attributes >>>> to header files, so that the checks are performed at all locations. >>> >>> Applied. Thanks >>> >> >> Thanks Alexei! >> >> I noticed the set was applied to the bpf-next tree, and not bpf. Just >> checking if this is intentional? > > Yes. I don't see the _fix_ part in there. > Looks like cleanup to me. > I've also considered to push > commit d34b044038bf ("tools: bpftool: close prog FD before exit on > showing a single program") > to bpf-next as well. > That fd leak didn't feel that necessary to push to bpf tree > and risk merge conflicts... but I pushed it to bpf at the end. > Ok, thanks for explaining. I'll consider submitting this kind of patches to bpf-next instead in the future. Quentin