From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andrew Halaney <ahalaney@redhat.com>, devicetree@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
alexandre.torgue@foss.st.com, peppe.cavallaro@st.com,
joabreu@synopsys.com, mripard@kernel.org, shenwei.wang@nxp.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio
Date: Tue, 14 Feb 2023 09:12:36 +0100 [thread overview]
Message-ID: <e4c33665-179b-8bf4-f7eb-38f86dceda56@linaro.org> (raw)
In-Reply-To: <20230213213104.78443-2-ahalaney@redhat.com>
On 13/02/2023 22:31, Andrew Halaney wrote:
> The property is named snps,reset-gpio. Update the name accordingly so
> the corresponding phy is reset.
>
> Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
> arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> index 1bcf228a22b8..b6d7c2526131 100644
> --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> @@ -121,7 +121,7 @@ &eqos {
> phy-handle = <ðphy0>;
> nvmem-cells = <&fec_mac1>;
> nvmem-cell-names = "mac-address";
> - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
> + snps,reset-gpio = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
I don't think it's correct change. This property is deprecated. Also
uses old, deprecated suffix gpio.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-14 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 21:31 [PATCH 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency Andrew Halaney
2023-02-13 21:31 ` [PATCH 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio Andrew Halaney
2023-02-13 21:47 ` Fabio Estevam
2023-02-14 8:12 ` Krzysztof Kozlowski [this message]
2023-02-14 14:15 ` Andrew Halaney
2023-02-14 8:11 ` [PATCH 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4c33665-179b-8bf4-f7eb-38f86dceda56@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).