From: Kui-Feng Lee <sinquersw@gmail.com>
To: Eric Dumazet <edumazet@google.com>, thinker.li@gmail.com
Cc: netdev@vger.kernel.org, martin.lau@linux.dev,
kernel-team@meta.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org, kuifeng@meta.com
Subject: Re: [PATCH bpf-next] ipv6: fix warning messages in fib6_info_release().
Date: Thu, 7 Dec 2023 12:24:53 -0800 [thread overview]
Message-ID: <e4d86104-0b66-4535-85bc-87bea2409a7e@gmail.com> (raw)
In-Reply-To: <CANn89i+CTAYZft=LT+ZH8bg__9p63URnQH=s9=AL7MO4rbvPJg@mail.gmail.com>
On 12/7/23 12:04, Eric Dumazet wrote:
> On Thu, Dec 7, 2023 at 8:50 PM <thinker.li@gmail.com> wrote:
>>
>> From: Kui-Feng Lee <thinker.li@gmail.com>
>>
>> The previous patch doesn't handle the case in ip6_route_info_create().
>> Move calling to fib6_set_expires_locked() to the end of the function to
>> avoid the false alarm of the previous patch.
>>
>> Fixes: 5a08d0065a91 ("ipv6: add debug checks in fib6_info_release()")
>
> This looks quite wrong.
>
> Let's separate things to have clean stable backports.
>
> I will submit my single liner, you will submit a patch fixing your prior commit,
> otherwise linux-6.6 and linux-6.7 will still have a bug.
Sure, I am working on that.
prev parent reply other threads:[~2023-12-07 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 19:50 [PATCH bpf-next] ipv6: fix warning messages in fib6_info_release() thinker.li
2023-12-07 20:04 ` Eric Dumazet
2023-12-07 20:24 ` Kui-Feng Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4d86104-0b66-4535-85bc-87bea2409a7e@gmail.com \
--to=sinquersw@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).