From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [patch net-next 09/20] net: sched: convert actions array into rcu list Date: Sun, 30 Jul 2017 16:17:24 -0400 Message-ID: References: <20170728144042.6380-1-jiri@resnulli.us> <20170728144042.6380-10-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, xiyou.wangcong@gmail.com, daniel@iogearbox.net, mlxsw@mellanox.com To: Jiri Pirko , netdev@vger.kernel.org Return-path: Received: from mail-io0-f194.google.com ([209.85.223.194]:36504 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754239AbdG3UR2 (ORCPT ); Sun, 30 Jul 2017 16:17:28 -0400 Received: by mail-io0-f194.google.com with SMTP id j32so12284529iod.3 for ; Sun, 30 Jul 2017 13:17:28 -0700 (PDT) In-Reply-To: <20170728144042.6380-10-jiri@resnulli.us> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 17-07-28 10:40 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Currently the actions are stored in array with array size. To traverse > this array in fastpath, tcf_tree_lock is taken to protect it. Convert > the array into a singly linked list, similar to the filter chains style > and allow traversal protected by rcu. > Looks sane. But lets have Cong provide an opinion (since he said he was trying to rcu the actions). cheers, jamal