From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next 1/2] tcp: remove redundant rcv_nxt update
Date: Wed, 11 Jul 2018 10:01:17 -0700
Message-ID: <e51e4a18-5e4d-f276-3d39-304424853351@gmail.com>
References: <1531315019-3553-1-git-send-email-laoar.shao@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        shaoyafang@didichuxing.com
To: Yafang Shao <laoar.shao@gmail.com>, davem@davemloft.net,
        edumazet@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f66.google.com ([209.85.160.66]:36854 "EHLO
        mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726460AbeGKRGc (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 11 Jul 2018 13:06:32 -0400
In-Reply-To: <1531315019-3553-1-git-send-email-laoar.shao@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 07/11/2018 06:16 AM, Yafang Shao wrote:
> tcp_rcv_nxt_update() is already executed in tcp_data_queue().
> This line is redundant.
> 
> See bellow,
> 	tcp_queue_rcv
> 		tcp_rcv_nxt_update(tcp_sk(sk), TCP_SKB_CB(skb)->end_seq);
> 	tcp_rcv_nxt_update(tp, TCP_SKB_CB(skb)->end_seq); <<<< redundant
> 
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> ---

This patch is fine (but not the following)

Signed-off-by: Eric Dumazet <edumazet@google.com>

Thanks.