Re: [PATCH net] net: marvell: prestera: disable port before changing its MAC mode

["Imre Kaloz" <kaloz@kernel.org>]

On Sun, Nov 15, 2026, at 11:59, netdev-bot+sashiko@kernel.org wrote:

<snip>

>> @@ -339,6 +340,17 @@ static int prestera_pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode,
>>  		break;
>>  	}
>>  
>> +	/* Firmware may not report link up after the mode or inband setting of
>> +	 * an enabled port changes until the port is disabled and re-enabled.
>> +	 */
>> +	if (old.admin && (old.mode != cfg_mac.mode ||
>> +			  old.inband != cfg_mac.inband)) {
>
> [Severity: Medium]
> Does this check catch a change between 2500BASE-X and SGMII?
No. Both use PRESTERA_MAC_MODE_SGMII and phylink selects inband for
both, so swapping a 2.5G module for an SGMII one on an enabled port
skips the disable. v2 will also compare the speed and set SPEED_1000
for SGMII, which is the speed the port already runs with on the SGMII
path I tested. I have no 2.5G module, so the 2500BASE-X case is
untested.


Imre

pw-bot: cr