From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Fomichev Subject: [PATCH bpf] selftests/bpf: add missing pointer dereference for map stacktrace fixup Date: Thu, 6 Dec 2018 20:14:11 -0800 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, bhole_prashant_q7@lab.ntt.co.jp, Stanislav Fomichev To: netdev@vger.kernel.org Return-path: Received: from mail-it1-f201.google.com ([209.85.166.201]:35786 "EHLO mail-it1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbeLGEOP (ORCPT ); Thu, 6 Dec 2018 23:14:15 -0500 Received: by mail-it1-f201.google.com with SMTP id c128so3534169itc.0 for ; Thu, 06 Dec 2018 20:14:15 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: I get a segfault without it, other fixups always do dereference, and without dereference I don't understand how it can ever work. Fixes: 7c85c448e7d74 ("selftests/bpf: test_verifier, check bpf_map_lookup_elem access in bpf prog") Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_verifier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c index df6f751cc1e8..d23929a1985d 100644 --- a/tools/testing/selftests/bpf/test_verifier.c +++ b/tools/testing/selftests/bpf/test_verifier.c @@ -14166,7 +14166,7 @@ static void do_test_fixup(struct bpf_test *test, enum bpf_map_type prog_type, do { prog[*fixup_map_stacktrace].imm = map_fds[12]; fixup_map_stacktrace++; - } while (fixup_map_stacktrace); + } while (*fixup_map_stacktrace); } } -- 2.20.0.rc2.403.gdbc3b29805-goog