From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Youghandhar Chintala <quic_youghand@quicinc.com>,
kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt: bindings: net: ath11k: add dt entry for XO calibration support
Date: Tue, 7 Feb 2023 11:36:31 +0100 [thread overview]
Message-ID: <e56a9985-001e-fb42-f916-94f2bb5d6d13@linaro.org> (raw)
In-Reply-To: <20230207103207.759-3-quic_youghand@quicinc.com>
On 07/02/2023 11:32, Youghandhar Chintala wrote:
> Add dt binding to get XO calibration data support for Wi-Fi RF clock.
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Several comments were ignored.
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
Subject: drop second/last, redundant "dt entry for". The "dt-bindings"
prefix is already stating that these are bindings.
dt-bindings: net: qcom,ath11k: add XO frequency offset
>
> Retrieve the XO trim offset via system firmware (e.g., device tree),
> especially in the case where the device doesn't have a useful EEPROM
> on which to store the calibrated XO offset.
> Calibrated XO offset is sent to firmware, which compensate the RF clock
> drift by programing the XO trim register.
>
> Signed-off-by: Youghandhar Chintala <quic_youghand@quicinc.com>
> ---
> .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> index f7cf135aa37f..4745251e70d4 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -41,6 +41,10 @@ properties:
> * reg
> * reg-names
>
> + xo-cal-data:
> + description:
> + XO frequency offset to program the XO trim register
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
(missing type/ref, vendor prefix).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-07 10:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 10:32 [PATCH v2 0/2] dt: bindings: add dt entry for XO calibration support Youghandhar Chintala
2023-02-07 10:32 ` [PATCH v3 0/2] dt: bindings: net: ath11k: " Youghandhar Chintala
2023-02-07 10:32 ` [PATCH v3 1/2] " Youghandhar Chintala
2023-02-07 10:36 ` Krzysztof Kozlowski [this message]
2023-02-07 10:32 ` [PATCH v3 2/2] wifi: ath11k: PMIC XO cal data support Youghandhar Chintala
2023-02-07 10:37 ` Robert Marko
-- strict thread matches above, loose matches on Subject: below --
2023-02-07 10:36 [PATCH v3 0/2] dt: bindings: net: ath11k: add dt entry for XO calibration support Youghandhar Chintala
2023-02-07 10:36 ` [PATCH v3 1/2] " Youghandhar Chintala
2023-02-07 10:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e56a9985-001e-fb42-f916-94f2bb5d6d13@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_youghand@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).