From: Florian Fainelli <f.fainelli@gmail.com>
To: Wei Wang <weiwan@google.com>, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Felix Fietkau <nbd@nbd.name>,
Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH net-next v7 3/3] net: add sysfs attribute to control napi threaded mode
Date: Wed, 20 Jan 2021 09:28:54 -0800 [thread overview]
Message-ID: <e5714161-d8ca-d5dd-f12c-a6b206558cf9@gmail.com> (raw)
In-Reply-To: <20210120033455.4034611-4-weiwan@google.com>
On 1/19/2021 7:34 PM, Wei Wang wrote:
> This patch adds a new sysfs attribute to the network device class.
> Said attribute provides a per-device control to enable/disable the
> threaded mode for all the napi instances of the given network device.
> User sets it to 1 or 0 to enable or disable threaded mode per device.
> However, when user reads from this sysfs entry, it could return:
> 1: means all napi instances belonging to this device have threaded
> mode enabled.
> 0: means all napi instances belonging to this device have threaded
> mode disabled.
> -1: means the system fails to enable threaded mode for certain napi
> instances when user requests to enable threaded mode. This happens
> when the kthread fails to be created for certain napi instances.
>
> Co-developed-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> Co-developed-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Co-developed-by: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Wei Wang <weiwan@google.com>
Can you document the new threaded sysfs attribute under
Documentation/ABI/testing/sysfs-class-net?
--
Florian
next prev parent reply other threads:[~2021-01-20 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 3:34 [PATCH net-next v7 0/3] implement kthread based napi poll Wei Wang
2021-01-20 3:34 ` [PATCH net-next v7 1/3] net: extract napi poll functionality to __napi_poll() Wei Wang
2021-01-20 3:34 ` [PATCH net-next v7 2/3] net: implement threaded-able napi poll loop support Wei Wang
2021-01-20 3:34 ` [PATCH net-next v7 3/3] net: add sysfs attribute to control napi threaded mode Wei Wang
2021-01-20 16:12 ` Alexander Duyck
2021-01-20 18:07 ` Wei Wang
2021-01-21 3:35 ` Alexander Duyck
2021-01-21 17:45 ` Wei Wang
2021-01-20 17:28 ` Florian Fainelli [this message]
2021-01-20 18:07 ` Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5714161-d8ca-d5dd-f12c-a6b206558cf9@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=kuba@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).